From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752825AbcADTnM (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 14:43:12 -0500
Received: from mga01.intel.com ([192.55.52.88]:34264 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751523AbcADTnK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 14:43:10 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,521,1444719600"; 
   d="scan'208";a="853385112"
Date: Mon, 4 Jan 2016 21:43:06 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Martin Wilck <Martin.Wilck@ts.fujitsu.com>,
        Peter Huewe <peterhuewe@gmx.de>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource
Message-ID: <20160104194306.GA19608@intel.com>
References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com>
 <1450376600-6970-8-git-send-email-jgunthorpe@obsidianresearch.com>
 <20160103173213.GF4155@intel.com>
 <20160104183025.GE20016@obsidianresearch.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160104183025.GE20016@obsidianresearch.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 04, 2016 at 11:30:25AM -0700, Jason Gunthorpe wrote:
> On Sun, Jan 03, 2016 at 07:32:13PM +0200, Jarkko Sakkinen wrote:
> > On Thu, Dec 17, 2015 at 11:23:20AM -0700, Jason Gunthorpe wrote:
> > > To support the force mode in tpm_tis we need to use resource locking
> > > in tpm_crb as well, via devm_ioremap_resource.
> > > 
> > > The light restructuring better aligns crb and tis and makes it easier
> > > to see the that new changes make sense.
> > 
> > This patch mixes two items: restructing and actual change.
> 
> Do you have a suggestion how to split this?
> 
> Everything is done for a reason, it isn't just churn for the sake of
> churn.

I'll appy this to master.

> Jason

/Jarkko