From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbcADTqy (ORCPT ); Mon, 4 Jan 2016 14:46:54 -0500 Received: from mail.skyhub.de ([78.46.96.112]:49075 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbcADTqv (ORCPT ); Mon, 4 Jan 2016 14:46:51 -0500 Date: Mon, 4 Jan 2016 20:46:29 +0100 From: Borislav Petkov To: Dinh Nguyen Cc: tthayer@opensource.altera.com, dinh.linux@gmail.com, dougthompson@xmission.com, mchehab@osg.samsung.com, linux@arm.linux.org.uk, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support Message-ID: <20160104194629.GN22941@pd.tnic> References: <1445978292-29918-1-git-send-email-dinguyen@opensource.altera.com> <20151119183421.GG6065@pd.tnic> <568AA929.1020801@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <568AA929.1020801@opensource.altera.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 11:17:29AM -0600, Dinh Nguyen wrote: > We tried to jam the L2 and OCRAM EDAC functionality in the same > altr_edac.c file. It looks like it might be clean if we split out the L2 > and OCRAM functions into their appropriate files(altr_edac_l2.c and > altr_edac_ocram.c). Do you agree? "Clean" in what sense? To me clean is when there's a single compilation unit altera_edac.c which contains all Altera-specific code. > These bindings were in a separate patch that you were not CC'd. I'll > keep you on the entire patch set in the future. Yes, I believe the devicetree definitions need to go hand-in-hand with its user(s). -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.