From: Darren Hart <dvhart@infradead.org>
To: Weng Xuetian <wengxt@gmail.com>
Cc: Chen Yu <yu.c.chen@intel.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3] surface pro 4: Add support for Surface Pro 4 Buttons
Date: Mon, 4 Jan 2016 12:11:10 -0800 [thread overview]
Message-ID: <20160104201110.GD26072@malice.jf.intel.com> (raw)
In-Reply-To: <1451244080-940-1-git-send-email-wengxt@gmail.com>
On Sun, Dec 27, 2015 at 11:21:20AM -0800, Weng Xuetian wrote:
> Surface Pro 4 buttons are managed by a device with _HID "MSHW0040"
> different from Surface Pro 3.
>
> This commit adds MSHW0040 to id list to support the Surface Pro 4, and
> renames the driver to surfacepro_button accordingly.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=109871
Is there a Surface Pro v1 and v2? If so, and they are not supported, then the 3
makes sense to keep. Or, at the very least, the Kconfig help and the comments in
the driver should make it clear that it supports v3 and later.
Chen, any concerns?
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-01-04 20:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 20:28 [PATCH] surface pro 4: Add support for Surface Pro 4 Buttons Weng Xuetian
2015-12-27 13:36 ` Andy Shevchenko
2015-12-27 17:29 ` [PATCH v2] " Weng Xuetian
2015-12-27 19:07 ` Chen, Yu C
2015-12-27 19:21 ` [PATCH v3] " Weng Xuetian
2015-12-27 20:58 ` Andy Shevchenko
2016-01-04 20:35 ` Darren Hart
2016-01-05 0:00 ` Chen, Yu C
2016-01-04 20:11 ` Darren Hart [this message]
2016-01-11 18:38 ` Darren Hart
2016-01-12 19:43 ` [PATCH v4] " Weng Xuetian
2016-01-14 23:01 ` Darren Hart
2016-01-15 1:41 ` Chen, Yu C
2016-01-15 1:50 ` Chen, Yu C
2016-01-17 23:10 ` [PATCH v5] " Weng Xuetian
2016-01-18 3:18 ` Chen, Yu C
2016-01-19 21:00 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104201110.GD26072@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wengxt@gmail.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).