From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbcADULM (ORCPT ); Mon, 4 Jan 2016 15:11:12 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:56482 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbcADULL (ORCPT ); Mon, 4 Jan 2016 15:11:11 -0500 Date: Mon, 4 Jan 2016 12:11:10 -0800 From: Darren Hart To: Weng Xuetian Cc: Chen Yu , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3] surface pro 4: Add support for Surface Pro 4 Buttons Message-ID: <20160104201110.GD26072@malice.jf.intel.com> References: <1451237389-7993-1-git-send-email-wengxt@gmail.com> <1451244080-940-1-git-send-email-wengxt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451244080-940-1-git-send-email-wengxt@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2015 at 11:21:20AM -0800, Weng Xuetian wrote: > Surface Pro 4 buttons are managed by a device with _HID "MSHW0040" > different from Surface Pro 3. > > This commit adds MSHW0040 to id list to support the Surface Pro 4, and > renames the driver to surfacepro_button accordingly. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=109871 Is there a Surface Pro v1 and v2? If so, and they are not supported, then the 3 makes sense to keep. Or, at the very least, the Kconfig help and the comments in the driver should make it clear that it supports v3 and later. Chen, any concerns? -- Darren Hart Intel Open Source Technology Center