From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753120AbcADUbL (ORCPT ); Mon, 4 Jan 2016 15:31:11 -0500 Received: from mail.skyhub.de ([78.46.96.112]:41886 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbcADUbH (ORCPT ); Mon, 4 Jan 2016 15:31:07 -0500 Date: Mon, 4 Jan 2016 21:30:46 +0100 From: Borislav Petkov To: Dinh Nguyen Cc: tthayer@opensource.altera.com, dinh.linux@gmail.com, dougthompson@xmission.com, mchehab@osg.samsung.com, linux@arm.linux.org.uk, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support Message-ID: <20160104203045.GO22941@pd.tnic> References: <1445978292-29918-1-git-send-email-dinguyen@opensource.altera.com> <20151119183421.GG6065@pd.tnic> <568AA929.1020801@opensource.altera.com> <20160104194629.GN22941@pd.tnic> <568AD038.7070200@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <568AD038.7070200@opensource.altera.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 02:04:08PM -0600, Dinh Nguyen wrote: > altr_edac.c originally added support for SDRAM. Now we're adding support > for L2 and OCRAM into the same file by using #ifdef > CONFIG_EDAC_ALTERA_OCRAM and CONFIG_EDAC_ALTERA_L2C. So "clean" was to > move the l2 and ocram implementation into separate files. So what's wrong with adding those to the same file and using different registration functions? Like xgene_edac does, for example. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.