From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbcADUbN (ORCPT ); Mon, 4 Jan 2016 15:31:13 -0500 Received: from down.free-electrons.com ([37.187.137.238]:49298 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752658AbcADUbH (ORCPT ); Mon, 4 Jan 2016 15:31:07 -0500 Date: Mon, 4 Jan 2016 21:30:59 +0100 From: Maxime Ripard To: Andre Przywara Cc: Vishnu Patekar , Linus Walleij , Chen-Yu Tsai , Hans de Goede , Catalin Marinas , will.deacon@arm.com, "linux-arm-kernel@lists.infradead.org" , linux-gpio@vger.kernel.org, "linux-sunxi@googlegroups.com" , linux-kernel@vger.kernel.org Subject: Re: [linux-sunxi] [RFC PATCH] drivers: pinctrl: add driver for Allwinner A64 SoC Message-ID: <20160104203059.GG11722@lukather> References: <1451582246-32373-1-git-send-email-andre.przywara@arm.com> <568A4972.8030602@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0z5c7mBtSy1wdr4F" Content-Disposition: inline In-Reply-To: <568A4972.8030602@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0z5c7mBtSy1wdr4F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andre, On Mon, Jan 04, 2016 at 10:29:06AM +0000, Andre Przywara wrote: > >> diff --git a/drivers/pinctrl/sunxi/Makefile b/drivers/pinctrl/sunxi/Ma= kefile > >> index e080290..130e7bc 100644 > >> --- a/drivers/pinctrl/sunxi/Makefile > >> +++ b/drivers/pinctrl/sunxi/Makefile > >> @@ -12,5 +12,6 @@ obj-$(CONFIG_PINCTRL_SUN7I_A20) +=3D p= inctrl-sun7i-a20.o > >> obj-$(CONFIG_PINCTRL_SUN8I_A23) +=3D pinctrl-sun8i-a23= =2Eo > >> obj-$(CONFIG_PINCTRL_SUN8I_A23_R) +=3D pinctrl-sun8i-a23-r.o > >> obj-$(CONFIG_PINCTRL_SUN8I_A33) +=3D pinctrl-sun8i-a33= =2Eo > >> +obj-$(CONFIG_PINCTRL_A64) +=3D pinctrl-a64.o > >=20 > > Shouldn't this follow pinctrl config name like other sunXi SOCs? > > This should be PINCTRL_SUN??_A64. >=20 > I never really got the reason we use those sunxi names in addition to > the SoC name in the first place, maybe apart from copying from some > Allwinner code. > Since I decided to not look at Allwinner's BSP at all (if avoidable), I > also thought it would be time to drop that sunxi naming, which looks > redundant to me. > Is there any reason why we would need this (beside having a rather > unique identifier prefix)? It's mostly historical. Back when we started this, There was a few SoCs already out: A10, A10s, A12 and A13, which was very similar to the Cortex-A naming scheme (and I think the Cortex-A12 was also announced at the time). We couldn't really use the SoC family either, since there was already multiple SoCs that were part of the same family (the A10s, A12 and A13, part of the sun5i family). In order to avoid any confusion, we chose to go with both to uniquely and without any confusion possible, and we just went on with that naming scheme for consistency. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --0z5c7mBtSy1wdr4F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWitaDAAoJEBx+YmzsjxAgZgAP/AmlIuvgTsl7Ao70tayj6y8i I8eShlzbdbsYgl/BNSh9jmdCAjlzIqu5Me7BBohpM1oEaQ2L7PFTr5FuCNn0DSEN ewXlNdKUHIxTP7ezih0unGzhbapzvzoccUX0GgeO7naxpbwqp1wSlJH6KUFm3X23 RknXfz/ZotdAa6CzYJ02AEa737fvadujKhJU6dvKzK1idPCjz5coWe8Y7jq+ngDR gQvSUAGOlA1xjJ9d/cDpKvaMQdd1g348449WKnnPjPKmpunOTaStmZvezgF3vBG1 oJ2wDsn/C9RYhiPn1MpYa4+LuXt5A73yVFWql6RnRhDQ9L+oSlnoLmPHmuyOwrJV pT8hYguLagYNYOlwQGKKXJJ6sYCewAypjA+D/rIrHc7dOuIllV27bSAkEboLLAjy T4mntaCoZ98fRKn5tV35z0ChX4kWwUPVOWOEYtM31kpo2olQIJNFV9QGsJYNSMCc 5nv9XYcZg8sLzWNIuDKBiDulWa/1VMikqdIBlsfHeAjX3NpmSkijN8BrBk8e6dah ia2h9GZW6pJZ84/N0hBOXjHuBfBGbaD4PPssdXcjSmYnzPPkngP6hj6YOz+K9qxE VhUCswxBxMfSBbetINXN2HQrVkoGut5YonClDMuWu8N5ETxcB+3cny+WoCpEjFRx gkJSV7ad+22mm85Dtqkq =xK4O -----END PGP SIGNATURE----- --0z5c7mBtSy1wdr4F--