From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbcADUk1 (ORCPT ); Mon, 4 Jan 2016 15:40:27 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:48478 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbcADUkY (ORCPT ); Mon, 4 Jan 2016 15:40:24 -0500 Date: Mon, 4 Jan 2016 12:40:20 -0800 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20160104204020.GC4219@malice.jf.intel.com> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <1451514461-31999-1-git-send-email-pali.rohar@gmail.com> <20160104200425.GC26072@malice.jf.intel.com> <201601042126.19417@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201601042126.19417@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote: > On Monday 04 January 2016 21:04:25 Darren Hart wrote: > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > > This patch adds support for controlling keyboard backlight via > > > standard linux led class interface (::kbd_backlight). It uses ACPI > > > HKEY device with MLCG and MLCS methods. > > > > Which laptops is this intended to support? > > Thinkpad ??30 series and new which have backlight keyboard. Thanks, we should include that in the commit message as well as the comments surrounding the driver section. Henrique, are your concerns surrounding suspend/resume resolved? -- Darren Hart Intel Open Source Technology Center