linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v3)
Date: Mon, 4 Jan 2016 18:17:46 -0300	[thread overview]
Message-ID: <20160104211746.GD15669@kernel.org> (raw)
In-Reply-To: <1450708013-7805-1-git-send-email-namhyung@kernel.org>

Em Mon, Dec 21, 2015 at 11:26:43PM +0900, Namhyung Kim escreveu:
> Hello,
> 
> This is an attempt to improve perf to deal with tracepoint events
> better.  The perf tools can handle tracepoint events but perf report
> on them is less useful since they're always sampled in a fixed
> location and not provide event specific info.  We can use perf script
> but I always wishes there's more convenient way to see the result.
> 
>  * changes in v3)
>   - save trace_output for dynamic entries  (Jiri)
>   - update field length for each entry

Thanks, applied, I made a few changes, related to libtraceevent function
names, split a patch in two, please take a look at my perf/core branch,
should all be ok.

Ah, please consider looking for field names directly, i.e. make this
work for a kmem:kmalloc event:

    perf report -s comm,gfp_flags

:-)

I think this can get mapped even when multiple events are available,
i.e. use that for the events that have such a field.

It could even get more relaxed, like:

    perf report -s comm,flags

No?

- Arnaldo

  parent reply	other threads:[~2016-01-04 21:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 14:26 [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v3) Namhyung Kim
2015-12-21 14:26 ` [PATCH 01/10] perf hist: Pass struct sample to __hists__add_entry() Namhyung Kim
2015-12-21 14:26 ` [PATCH 02/10] perf hist: Save raw_data/size for tracepoint events Namhyung Kim
2015-12-21 14:26 ` [PATCH 03/10] tools lib traceevent: Factor out and export print_event_field[s] Namhyung Kim
2015-12-21 14:26 ` [PATCH 04/10] perf tools: Pass evlist to setup_sorting() Namhyung Kim
2015-12-21 14:26 ` [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events Namhyung Kim
2016-01-05 10:38   ` Jiri Olsa
2015-12-21 14:26 ` [PATCH 06/10] perf tools: Try to show pretty printed output for dynamic sort keys Namhyung Kim
2015-12-21 14:26 ` [PATCH 07/10] perf tools: Add 'trace' sort key Namhyung Kim
2015-12-22  7:22   ` Jiri Olsa
2015-12-22 14:47     ` Namhyung Kim
2015-12-21 14:26 ` [PATCH 08/10] perf tools: Add --raw-trace option Namhyung Kim
2015-12-21 14:26 ` [PATCH 09/10] perf tools: Make 'trace' sort key default for tracepoint events Namhyung Kim
2015-12-22  7:29   ` Jiri Olsa
2015-12-22 14:49     ` Namhyung Kim
2015-12-21 14:26 ` [PATCH 10/10] perf tools: Support shortcuts for events in dynamic sort keys Namhyung Kim
2016-01-04 21:17 ` Arnaldo Carvalho de Melo [this message]
2016-01-05  0:22   ` [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v3) Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104211746.GD15669@kernel.org \
    --to=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).