From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbcADVRy (ORCPT ); Mon, 4 Jan 2016 16:17:54 -0500 Received: from mail.kernel.org ([198.145.29.136]:49721 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbcADVRu (ORCPT ); Mon, 4 Jan 2016 16:17:50 -0500 Date: Mon, 4 Jan 2016 18:17:46 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Steven Rostedt , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: Re: [PATCHSET 00/10] perf tools: Support dynamic sort keys for tracepoints (v3) Message-ID: <20160104211746.GD15669@kernel.org> References: <1450708013-7805-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450708013-7805-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 21, 2015 at 11:26:43PM +0900, Namhyung Kim escreveu: > Hello, > > This is an attempt to improve perf to deal with tracepoint events > better. The perf tools can handle tracepoint events but perf report > on them is less useful since they're always sampled in a fixed > location and not provide event specific info. We can use perf script > but I always wishes there's more convenient way to see the result. > > * changes in v3) > - save trace_output for dynamic entries (Jiri) > - update field length for each entry Thanks, applied, I made a few changes, related to libtraceevent function names, split a patch in two, please take a look at my perf/core branch, should all be ok. Ah, please consider looking for field names directly, i.e. make this work for a kmem:kmalloc event: perf report -s comm,gfp_flags :-) I think this can get mapped even when multiple events are available, i.e. use that for the events that have such a field. It could even get more relaxed, like: perf report -s comm,flags No? - Arnaldo