From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbcADVmI (ORCPT ); Mon, 4 Jan 2016 16:42:08 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:55458 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753368AbcADVmD (ORCPT ); Mon, 4 Jan 2016 16:42:03 -0500 Date: Mon, 4 Jan 2016 13:42:00 -0800 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20160104214200.GE4219@malice.jf.intel.com> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <201601042126.19417@pali> <20160104204020.GC4219@malice.jf.intel.com> <201601042151.23995@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201601042151.23995@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 09:51:23PM +0100, Pali Rohár wrote: > On Monday 04 January 2016 21:40:20 Darren Hart wrote: > > On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote: > > > On Monday 04 January 2016 21:04:25 Darren Hart wrote: > > > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > > > > This patch adds support for controlling keyboard backlight via > > > > > standard linux led class interface (::kbd_backlight). It uses > > > > > ACPI HKEY device with MLCG and MLCS methods. > > > > > > > > Which laptops is this intended to support? > > > > > > Thinkpad ??30 series and new which have backlight keyboard. > > > > Thanks, we should include that in the commit message as well as the > > comments surrounding the driver section. > > ??30 is probably not good characteristic, but I mean all those Thinkpad > laptops like T430, x230, E430, X1 (1st) and their successors (T440, > T450, X1 3rd, ...) All those which are from Ivy Bridge processor > generation (and new). > > But basically it cover all Thinkpad laptops which have backlight > keyboard. Older Thinkpad laptops had only light in bezel. > > So if you have better idea for commit message, feel free to change it. Ah, I see. New feature that didn't exist previously. OK, no need for changes on that score then. -- Darren Hart Intel Open Source Technology Center