From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753164AbcADVtv (ORCPT ); Mon, 4 Jan 2016 16:49:51 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54407 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcADVtu (ORCPT ); Mon, 4 Jan 2016 16:49:50 -0500 Date: Mon, 4 Jan 2016 13:49:24 -0800 From: Greg Kroah-Hartman To: "Geyslan G. Bem" Cc: Alan Stern , LKML , linux-usb@vger.kernel.org Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast Message-ID: <20160104214924.GA13959@kroah.com> References: <11dd04072f65c0b168a9d842549c3705a34076b3.1451937845.git.geyslan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 06:40:38PM -0300, Geyslan G. Bem wrote: > 2016-01-04 17:58 GMT-03:00 Alan Stern : > > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > > > >> This patch fixes coding style issues reported by checkpatch concerning > >> to unnecessary space after a cast. > > > > This is a case where checkpatch is wrong, IMO. Casts should always be > > followed by a space. I will not accept this patch. > Ok. I understand. > > > > > This must be something recently added to checkpatch. It never used to > > complain about casts, whether they were followed by a space or not. > I'm using the checkpatch --strict option. Please never use that on existing kernel code, except for drivers/staging/ stuff, otherwise your patches will start to very quickly be ignored. thanks, greg k-h