From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754120AbcAEC3g (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 21:29:36 -0500
Received: from mail-pf0-f180.google.com ([209.85.192.180]:34374 "EHLO
	mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754101AbcAEC3b (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 21:29:31 -0500
Date: Mon, 4 Jan 2016 18:29:28 -0800
From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Daniel Kurtz <djkurtz@chromium.org>,
        Marek Vasut <marex@denx.de>, Bayi Cheng <bayi.cheng@mediatek.com>,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Felix Fietkau <nbd@openwrt.org>,
        Eddie Huang =?utf-8?B?KOm7g+aZuuWCkSk=?= 
	<eddie.huang@mediatek.com>,
        Milton Chiang =?utf-8?B?KOaxn+aYjuaZjyk=?= 
	<Milton.Chiang@mediatek.com>
Subject: Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions
 (aliased with Winbond)
Message-ID: <20160105022928.GF109450@google.com>
References: <1450205301-32207-1-git-send-email-computersforpeace@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450205301-32207-1-git-send-email-computersforpeace@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 15, 2015 at 10:48:20AM -0800, Brian Norris wrote:
> Spansion and Winbond have occasionally used the same manufacturer ID,
> and they don't support the same features. Particularly, writing SR=0
> seems to break read access for Spansion's s25fl064k. Unfortunately, we
> don't currently have a way to differentiate these Spansion and Winbond
> parts, so rather than regressing support for these Spansion flash, let's
> drop the new Winbond lock/unlock support for now. We can try to address
> Winbond support during the next release cycle.
> 
> Original discussion:
> 
> http://patchwork.ozlabs.org/patch/549173/
> http://patchwork.ozlabs.org/patch/553683/
> 
> Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for Winbond")
> Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash at startup")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Reported-by: Felix Fietkau <nbd@openwrt.org>
> Cc: Felix Fietkau <nbd@openwrt.org>

Felix,

Can I get a Tested-by? I'm going to send this for 4.4 still, if
possible.

Brian