From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754118AbcAEEm4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 23:42:56 -0500
Received: from mga04.intel.com ([192.55.52.120]:29632 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753913AbcAEEmv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 23:42:51 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,523,1444719600"; 
   d="scan'208";a="720332623"
Date: Tue, 5 Jan 2016 10:16:19 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sinan Kaya <okaya@codeaurora.org>, dmaengine <dmaengine@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Timur Tabi <timur@codeaurora.org>,
        devicetree <devicetree@vger.kernel.org>,
        Christopher Covington <cov@codeaurora.org>, jcm@redhat.com,
        Andy Gross <agross@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
        linux-arm-msm@vger.kernel.org,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V11 3/7] dma: add Qualcomm Technologies HIDMA management
 driver
Message-ID: <20160105044619.GJ2940@localhost>
References: <1451865996-12808-1-git-send-email-okaya@codeaurora.org>
 <1451865996-12808-4-git-send-email-okaya@codeaurora.org>
 <CAHp75Vd49-1H+1dkDmJzLpVhov1g+uJV+YiTBC9Xd3hVTmwRVg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vd49-1H+1dkDmJzLpVhov1g+uJV+YiTBC9Xd3hVTmwRVg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 04, 2016 at 08:37:30PM +0200, Andy Shevchenko wrote:

> > +static int set_priority(struct hidma_mgmt_dev *mdev, unsigned int i, u64 val)
> > +{
> > +       u64 tmp;
> > +       int rc;
> > +
> > +       if (i > mdev->dma_channels)
> 
> Shouldn't be >= ? I somehow missed that.

There is no merit is posting not related context while replying, makes your
emails harder to read, please fix that

> > +               return -EINVAL;
> > +
> > +       tmp = mdev->priority[i];
> > +       mdev->priority[i] = val;
> > +       rc = hidma_mgmt_setup(mdev);
> > +       if (rc)
> > +               mdev->priority[i] = tmp;
> > +       return rc;
> > +}
> > +
> > +static int set_weight(struct hidma_mgmt_dev *mdev, unsigned int i, u64 val)
> > +{
> > +       u64 tmp;
> > +       int rc;
> > +
> > +       if (i > mdev->dma_channels)
> 
> Ditto.

Exactly, ditto...


-- 
~Vinod