From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751936AbcAEKoE (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 05:44:04 -0500
Received: from mail-pa0-f54.google.com ([209.85.220.54]:33344 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751478AbcAEKoC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 05:44:02 -0500
Date: Tue, 5 Jan 2016 19:43:07 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [RFC/PATCH] perf report: Show random usage tip on the help line
Message-ID: <20160105104307.GA13561@danjae.kornet>
References: <1451972206-22481-1-git-send-email-namhyung@kernel.org>
 <568B638F.1030208@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <568B638F.1030208@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Tue, Jan 05, 2016 at 02:32:47PM +0800, Wangnan (F) wrote:
> 
> 
> On 2016/1/5 13:36, Namhyung Kim wrote:
> >Currently perf report only shows a help message "For a higher level
> >overview, try: perf report --sort comm,dso" unconditionally (even if
> >the sort keys were used).  Add more help tips and show randomly.
> >
> >Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> >---
> 
> That's really funny.

Thanks for your feedback!

> 
> Some inconvenience:
> 
>  1. Tip is never change during one execution of 'perf report', even if
>     I switch to another view using 'enter' and switch back. It should better
>     if tips updated when redrawing.

Hmm.. I think it's a preference.  I'd go for simplicity then. :)


> 
>  2. I think add a "Tip: " prefix to the content should be better, or users
> may confuse what he/her doing causes this message

OK.

> 
>  3. What about creating a tools/perf/Documentation/tips.txt and generate
> tips table dynamically?

I don't see much difference doing that.  I guess most of users don't
want to go to see the documentation anyway.  Do I miss something?

Btw, does anyone have some tips to add? :)

Thanks,
Namhyung