From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbcAEK7F (ORCPT ); Tue, 5 Jan 2016 05:59:05 -0500 Received: from mail.skyhub.de ([78.46.96.112]:47511 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcAEK67 (ORCPT ); Tue, 5 Jan 2016 05:58:59 -0500 Date: Tue, 5 Jan 2016 11:58:57 +0100 From: Borislav Petkov To: Thor Thayer Cc: Dinh Nguyen , dinh.linux@gmail.com, dougthompson@xmission.com, mchehab@osg.samsung.com, linux@arm.linux.org.uk, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support Message-ID: <20160105105857.GA3718@pd.tnic> References: <20160104194629.GN22941@pd.tnic> <568AD038.7070200@opensource.altera.com> <20160104203045.GO22941@pd.tnic> <568ADA22.70109@opensource.altera.com> <20160104205912.GQ22941@pd.tnic> <568ADC4F.6030007@opensource.altera.com> <20160104210726.GS22941@pd.tnic> <568AE523.7010905@opensource.altera.com> <20160104220100.GT22941@pd.tnic> <568B0370.7080500@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <568B0370.7080500@opensource.altera.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 05:42:40PM -0600, Thor Thayer wrote: > and then the defines are also used to conditionally include the L2 or OCRAM > ECC functions because everything is in one file. So? You don't have to do those funny games in the Makefile. Instead, you have your main CONFIG_EDAC_ALTERA_MC option and all the other CONFIG_* options depend on it. The ifdeffery in altera_edac.c then takes care of what needs to be enabled or not. However(!), your driver is not huge or something. So I still don't understand why you need that split and those additional config options and why not keep it all together in one file. What is the compelling use case for that split and additional complexity? > However, the highbank and octeon edacs are split into separate files for L2 > which Dinh pointed may be cleaner for individual control. I should've nacked that split at the time. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.