From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Olof Johansson <olof@lixom.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular
Date: Tue, 5 Jan 2016 10:59:32 -0500 [thread overview]
Message-ID: <20160105155932.GT12458@windriver.com> (raw)
In-Reply-To: <CAK7LNARdg5UCU99mL6Jhz_rHgyOkQ=pugdSMz_BmFRxH-eYSsA@mail.gmail.com>
[Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular] On 05/01/2016 (Tue 11:31) Masahiro Yamada wrote:
> 2016-01-05 11:26 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Hi Paul,
> >
[...]
> >
> >
> > I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> > is a temporary fix.
> >
> > I'd like to revive the tristate for this driver
> > by hook or by crook.
> >
> >
> > I've sent the following to fix the build error.
> > http://www.thefreedictionary.com/
>
> Sorry, I mean this one:
> https://patchwork.kernel.org/patch/7952361/
Sure, I'll shelf it and assume it will get back to tristate.
Note however that the patch I was looking at was not 326ea. It was
commit 6c741c74092c61465af206672ba567940a23d709
Author: Daniel Kurtz <djkurtz@chromium.org>
Date: Tue Dec 22 21:46:37 2015 +0800
pinctrl: mediatek: convert to arch_initcall
..and if you make it tristate again, you defeat the above change,
since if you look at module.h, you will see for the =m config:
#define arch_initcall(fn) module_init(fn)
...meaning that the change in 6c741c does nothing if =m is set.
I don't know if that is an issue or not, perhaps Daniel can comment.
Paul.
--
>
>
>
> --
> Best Regards
> Masahiro Yamada
prev parent reply other threads:[~2016-01-05 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 19:22 [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular Paul Gortmaker
2016-01-04 23:15 ` Masahiro Yamada
2016-01-04 23:24 ` Masahiro Yamada
2016-01-05 2:26 ` Masahiro Yamada
2016-01-05 2:31 ` Masahiro Yamada
2016-01-05 15:59 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105155932.GT12458@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox