From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "João Paulo Rechi Vita" <jprvita@gmail.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [PATCH 0/2] Asus Wireless Radio Control driver
Date: Tue, 5 Jan 2016 09:18:18 -0800 [thread overview]
Message-ID: <20160105171818.GF4219@malice.jf.intel.com> (raw)
In-Reply-To: <CAHp75VeFvqvWNcNtOLnzoxsW+MRk8G__QQjZ73H4S-vz9oR9og@mail.gmail.com>
On Tue, Jan 05, 2016 at 03:58:46PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 5, 2016 at 3:25 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
> > This series implements the driver for the "Asus Wireless Radio Control" device,
> > as named on the vendor website, which handles notifications from the airplane
> > mode hotkey and drives the airplane mode indicator LED. This device appears in
> > the DSDT as "ASHS".
> >
> > I decided to split the series and move the commits that drive the LED to a
> > separate series, so this part can be merged without waiting for feedback on the
> > new airplane mode RFKill LED trigger.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> (I'm fine with current version but please take into consideration
> comments to the first patch, most important 'default m' thing)
Agreed on the 'default m' thing. Thank you for the review Andy.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2016-01-05 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 13:25 [PATCH 0/2] Asus Wireless Radio Control driver João Paulo Rechi Vita
2016-01-05 13:26 ` [PATCH 1/2] platform/x86: Add " João Paulo Rechi Vita
2016-01-05 13:50 ` Andy Shevchenko
2016-01-05 16:16 ` [PATCH] " João Paulo Rechi Vita
2016-01-05 17:26 ` Darren Hart
2016-01-05 13:26 ` [PATCH 2/2] asus-wireless: Add ACPI HID ATK4001 João Paulo Rechi Vita
2016-01-05 17:27 ` Darren Hart
2016-01-05 13:58 ` [PATCH 0/2] Asus Wireless Radio Control driver Andy Shevchenko
2016-01-05 16:18 ` João Paulo Rechi Vita
2016-01-05 17:18 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105171818.GF4219@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=jprvita@endlessm.com \
--cc=jprvita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox