From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754642AbcAEVJe (ORCPT ); Tue, 5 Jan 2016 16:09:34 -0500 Received: from mail.skyhub.de ([78.46.96.112]:36888 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbcAEVJ1 (ORCPT ); Tue, 5 Jan 2016 16:09:27 -0500 Date: Tue, 5 Jan 2016 22:09:24 +0100 From: Borislav Petkov To: Thor Thayer Cc: Dinh Nguyen , dinh.linux@gmail.com, dougthompson@xmission.com, mchehab@osg.samsung.com, linux@arm.linux.org.uk, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support Message-ID: <20160105210923.GA5653@pd.tnic> References: <20160104203045.GO22941@pd.tnic> <568ADA22.70109@opensource.altera.com> <20160104205912.GQ22941@pd.tnic> <568ADC4F.6030007@opensource.altera.com> <20160104210726.GS22941@pd.tnic> <568AE523.7010905@opensource.altera.com> <20160104220100.GT22941@pd.tnic> <568B0370.7080500@opensource.altera.com> <20160105105857.GA3718@pd.tnic> <568C299C.2000406@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <568C299C.2000406@opensource.altera.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 02:37:48PM -0600, Thor Thayer wrote: > The CONFIG_EDAC_ALTERA_MC is a little confusing because it refers to the > Memory Controller (SDRAM) and uses that in the menu string(Altera SDRAM > Memory Controller EDAC). > > Would it be confusing to rename this CONFIG_EDAC_ALTERA, update the SDRAM > code to check the ECC Enable bit instead of this config option and update > the string in the menu? Sounds good to me. > I'll keep this as one file and implement your suggested changes and > resubmit. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.