From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752486AbcAEXjK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 18:39:10 -0500
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:49166 "EHLO
	lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752438AbcAEXjI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 18:39:08 -0500
X-Original-SENDERIP: 156.147.1.125
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 165.244.98.204
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 10.177.227.17
X-Original-MAILFROM: namhyung@kernel.org
Date: Wed, 6 Jan 2016 08:39:01 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH v2 1/5] perf tools: Fix segfault when using -s
 trace_fields
Message-ID: <20160105233901.GC18895@sejong>
References: <1451991518-25673-1-git-send-email-namhyung@kernel.org>
 <20160105215002.GC25916@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20160105215002.GC25916@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/01/06 08:39:03,
	Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/01/06 08:39:03,
	Serialize complete at 2016/01/06 08:39:03
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 05, 2016 at 06:50:02PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 05, 2016 at 07:58:34PM +0900, Namhyung Kim escreveu:
> > When the 'trace_fields' sort key is used explicitly for non-tracepoint
> > events, it'll get segfault since it assumed evsel->tp_format was set.
> > Skip those events in add_all_dynamic_fields().
> > 
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> Merged with the patch introducing this problem, that I hadn't sent to
> Ingo,

Thanks for doing that!
Namhyung


> 
> > ---
> >  tools/perf/util/sort.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index e558e87cafaf..59c4c8586d79 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -1955,6 +1955,9 @@ static int add_all_dynamic_fields(struct perf_evlist *evlist, bool raw_trace)
> >  	struct perf_evsel *evsel;
> >  
> >  	evlist__for_each(evlist, evsel) {
> > +		if (evsel->attr.type != PERF_TYPE_TRACEPOINT)
> > +			continue;
> > +
> >  		ret = add_evsel_fields(evsel, raw_trace);
> >  		if (ret < 0)
> >  			return ret;
> > -- 
> > 2.6.4