From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbcAFJKA (ORCPT ); Wed, 6 Jan 2016 04:10:00 -0500 Received: from mga11.intel.com ([192.55.52.93]:22064 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752520AbcAFJJz (ORCPT ); Wed, 6 Jan 2016 04:09:55 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,528,1444719600"; d="scan'208";a="854483436" Date: Wed, 6 Jan 2016 14:43:23 +0530 From: Vinod Koul To: Rameshswar Prasad Sahu Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, kgondkar@apm.com Subject: Re: [PATCH] dmaengine: xgene-dma: Fix double IRQ issue by setting IRQ_DISABLE_UNLAZY flag Message-ID: <20160106091323.GP2940@localhost> References: <1450875495-2229-1-git-send-email-rsahu@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450875495-2229-1-git-send-email-rsahu@apm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2015 at 06:28:15PM +0530, Rameshswar Prasad Sahu wrote: > From: Rameshwar Prasad Sahu > > For interrupt controller that doesn't support irq_disable and hardware > with level interrupt, an extra interrupt can be pending. This patch fixes > the issue by setting IRQ_DISABLE_UNLAZY flag for the interrupt line. > > Reference: http://git.kernel.org/tip/e9849777d0e27cdd2902805be51da73e7c79578c I seem to have got this patch thrice :( > > Signed-off-by: Rameshwar Prasad Sahu > --- > drivers/dma/xgene-dma.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c > index 9dfa2b0..6363e84 100644 > --- a/drivers/dma/xgene-dma.c > +++ b/drivers/dma/xgene-dma.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1610,6 +1611,7 @@ static int xgene_dma_request_irqs(struct xgene_dma *pdma) > /* Register DMA channel rx irq */ > for (i = 0; i < XGENE_DMA_MAX_CHANNEL; i++) { > chan = &pdma->chan[i]; > + irq_set_status_flags(chan->rx_irq, IRQ_DISABLE_UNLAZY); Why not use irq_settings_disable_unlazy(), at least read the reference you pointed out! > ret = devm_request_irq(chan->dev, chan->rx_irq, > xgene_dma_chan_ring_isr, > 0, chan->name, chan); > @@ -1620,6 +1622,7 @@ static int xgene_dma_request_irqs(struct xgene_dma *pdma) > > for (j = 0; j < i; j++) { > chan = &pdma->chan[i]; > + irq_clear_status_flags(chan->rx_irq, IRQ_DISABLE_UNLAZY); > devm_free_irq(chan->dev, chan->rx_irq, chan); > } > > @@ -1640,6 +1643,7 @@ static void xgene_dma_free_irqs(struct xgene_dma *pdma) > > for (i = 0; i < XGENE_DMA_MAX_CHANNEL; i++) { > chan = &pdma->chan[i]; > + irq_clear_status_flags(chan->rx_irq, IRQ_DISABLE_UNLAZY); > devm_free_irq(chan->dev, chan->rx_irq, chan); > } > } > -- > 1.7.1 -- ~Vinod