From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbcAFJRI (ORCPT ); Wed, 6 Jan 2016 04:17:08 -0500 Received: from mga03.intel.com ([134.134.136.65]:64692 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbcAFJRE (ORCPT ); Wed, 6 Jan 2016 04:17:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,528,1444719600"; d="scan'208";a="887296792" Date: Wed, 6 Jan 2016 14:50:32 +0530 From: Vinod Koul To: "Shevchenko, Andriy" Cc: "mans@mansr.com" , "vireshk@kernel.org" , "linux-kernel@vger.kernel.org" , "Williams, Dan J" , "dmaengine@vger.kernel.org" Subject: Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain Message-ID: <20160106092032.GR2940@localhost> References: <1450725037-26492-1-git-send-email-mans@mansr.com> <1450726452.30729.259.camel@linux.intel.com> <1450803309.30729.306.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450803309.30729.306.camel@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2015 at 10:24:49PM +0530, Shevchenko, Andriy wrote: > On Mon, 2015-12-21 at 21:34 +0200, Andy Shevchenko wrote: > > On Mon, 2015-12-21 at 19:10 +0000, Mans Rullgard wrote: > > > The datasheet requires that the LLP_[SD]_EN bits be cleared > > > whenever > > > LLP.LOC is zero, i.e. in the last descriptor of a multi-block > > > chain. > > > Make the driver do this. > > > > Acked-by: Andy Shevchenko > > Vinod, I would like to postpone this patch for a while to make a bit > easier back porting of other dw_dmac changes wrt fix SATA on 460EX (*). > > I will send it later in a bunch. Hope Måns has no objections on this. Okay by me as long as Måns is okay -- ~Vinod