From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbcAFMGc (ORCPT ); Wed, 6 Jan 2016 07:06:32 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35501 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbcAFMG2 (ORCPT ); Wed, 6 Jan 2016 07:06:28 -0500 Date: Wed, 6 Jan 2016 17:36:08 +0530 From: Sudip Mukherjee To: Sudeep Dutt Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, "Dixit, Ashutosh" Subject: Re: [PATCH char-misc-next 4/4] misc: mic: use common error path Message-ID: <20160106120608.GA28646@sudip-pc> References: <1448279672-12208-1-git-send-email-sudipm.mukherjee@gmail.com> <1448279672-12208-4-git-send-email-sudipm.mukherjee@gmail.com> <1449888385.93285.547.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449888385.93285.547.camel@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2015 at 06:46:25PM -0800, Sudeep Dutt wrote: > On Mon, 2015-11-23 at 17:24 +0530, Sudip Mukherjee wrote: > > Instead of calling release_firmware() on every error and then jumping > > lets have a common release_firmware() in the error path. > > This patch also fixes a memory leak where we missed release_firmware() > > if mic_x100_load_command_line() fails. > > > > Thanks for this patch series Sudip. All 4 patches look good. > > Reviewed-by: Sudeep Dutt Hi Greg, If your tree is not yet closed then a gentle ping for this series. regards sudip