From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752229AbcAFNIQ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jan 2016 08:08:16 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:41232 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751601AbcAFNIO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jan 2016 08:08:14 -0500
Date: Wed, 6 Jan 2016 13:08:00 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jens Axboe <axboe@fb.com>, Asai Thambi SP <asamymuthupa@micron.com>,
        Selvan Mani <smani@micron.com>, Jeff Moyer <jmoyer@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: calling kfree() on an error pointer
Message-ID: <20160106130800.GS9938@ZenIV.linux.org.uk>
References: <20160106100503.GH23185@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160106100503.GH23185@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> which is a bug.

Mind if I fold it (with credit, obviously)?