From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752528AbcAFNRO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jan 2016 08:17:14 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:47328 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751330AbcAFNRM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jan 2016 08:17:12 -0500
Date: Wed, 6 Jan 2016 16:16:50 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jens Axboe <axboe@fb.com>, Asai Thambi SP <asamymuthupa@micron.com>,
        Selvan Mani <smani@micron.com>, Jeff Moyer <jmoyer@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: calling kfree() on an error pointer
Message-ID: <20160106131650.GH23363@mwanda>
References: <20160106100503.GH23185@mwanda>
 <20160106130800.GS9938@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160106130800.GS9938@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 06, 2016 at 01:08:00PM +0000, Al Viro wrote:
> On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> > If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> > which is a bug.
> 
> Mind if I fold it (with credit, obviously)?

No problem, that's fine.

regards,
dan carpenter