From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jens Axboe <axboe@fb.com>,
Asai Thambi SP <asamymuthupa@micron.com>,
Selvan Mani <smani@micron.com>, Jeff Moyer <jmoyer@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: calling kfree() on an error pointer
Date: Wed, 6 Jan 2016 13:26:13 +0000 [thread overview]
Message-ID: <20160106132613.GT9938@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160106131650.GH23363@mwanda>
On Wed, Jan 06, 2016 at 04:16:50PM +0300, Dan Carpenter wrote:
> On Wed, Jan 06, 2016 at 01:08:00PM +0000, Al Viro wrote:
> > On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> > > If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> > > which is a bug.
> >
> > Mind if I fold it (with credit, obviously)?
>
> No problem, that's fine.
Done.
prev parent reply other threads:[~2016-01-06 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 10:05 [patch] mtip32xx: calling kfree() on an error pointer Dan Carpenter
2016-01-06 13:08 ` Al Viro
2016-01-06 13:16 ` Dan Carpenter
2016-01-06 13:26 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106132613.GT9938@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=asamymuthupa@micron.com \
--cc=axboe@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=jmoyer@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mhocko@suse.com \
--cc=smani@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).