public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan <gnomes@lxorguk.ukuu.org.uk>
To: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: [PATCH 1/8] goldfish: refactor goldfish platform configs
Date: Wed, 06 Jan 2016 14:04:13 +0000	[thread overview]
Message-ID: <20160106140400.3661.13261.stgit@localhost.localdomain> (raw)
In-Reply-To: <20160106140206.3661.6376.stgit@localhost.localdomain>

From: Greg Hackmann <ghackmann@google.com>

On new virtual devices, the goldfish virtual bus can be replaced with
autoprobing infrastructure like Device Tree.  Refactor the goldfish
kernel configs to better accommodate this.

Move the goldfish platform into a menuconfig in the style of the chrome
platform, and separate the goldfish bus into its own config option.

Signed-off-by: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Jin Qian <jinqian@android.com>
[Corrected a tristate to bool]
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
 drivers/platform/Kconfig           |    3 +--
 drivers/platform/goldfish/Kconfig  |   18 ++++++++++++++++++
 drivers/platform/goldfish/Makefile |    2 +-
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig
index 0adccbf..c11db8b 100644
--- a/drivers/platform/Kconfig
+++ b/drivers/platform/Kconfig
@@ -4,8 +4,7 @@ endif
 if MIPS
 source "drivers/platform/mips/Kconfig"
 endif
-if GOLDFISH
+
 source "drivers/platform/goldfish/Kconfig"
-endif
 
 source "drivers/platform/chrome/Kconfig"
diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
index 635ef25..2be7627 100644
--- a/drivers/platform/goldfish/Kconfig
+++ b/drivers/platform/goldfish/Kconfig
@@ -1,5 +1,23 @@
+menuconfig GOLDFISH
+	bool "Platform support for Goldfish virtual devices"
+	depends on X86_32 || X86_64 || ARM || ARM64
+	---help---
+	  Say Y here to get to see options for the Goldfish virtual platform.
+	  This option alone does not add any kernel code.
+
+	  Unless you are building for the Android Goldfish emulator say N here.
+
+if GOLDFISH
+
+config GOLDFISH_BUS
+	bool "Goldfish platform bus"
+	---help---
+	  This is a virtual bus to host Goldfish Android Virtual Devices.
+
 config GOLDFISH_PIPE
 	tristate "Goldfish virtual device for QEMU pipes"
 	---help---
 	  This is a virtual device to drive the QEMU pipe interface used by
 	  the Goldfish Android Virtual Device.
+
+endif # GOLDFISH
diff --git a/drivers/platform/goldfish/Makefile b/drivers/platform/goldfish/Makefile
index a002239..d348712 100644
--- a/drivers/platform/goldfish/Makefile
+++ b/drivers/platform/goldfish/Makefile
@@ -1,5 +1,5 @@
 #
 # Makefile for Goldfish platform specific drivers
 #
-obj-$(CONFIG_GOLDFISH)	+=	pdev_bus.o
+obj-$(CONFIG_GOLDFISH_BUS)	+= pdev_bus.o
 obj-$(CONFIG_GOLDFISH_PIPE)	+= goldfish_pipe.o


  reply	other threads:[~2016-01-06 14:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 14:03 [PATCH 0/8] Goldfish: partial resync with Google tree Alan
2016-01-06 14:04 ` Alan [this message]
2016-01-06 14:04 ` [PATCH 2/8] android_pipe: don't be clever with #define offsets Alan
2016-01-06 14:05 ` [PATCH 3/8] android_pipe: Pin pages to memory while copying and other cleanups Alan
2016-01-06 14:05 ` [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings Alan
2016-01-06 14:05 ` [PATCH 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN Alan
2016-01-06 14:06 ` [PATCH 6/8] [MIPS] Enable platform support for Goldfish virtual devices Alan
2016-01-06 14:06 ` [PATCH 7/8] goldfish_pipe: Pass physical addresses to the device if supported Alan
2016-01-06 14:06 ` [PATCH 8/8] goldfish: Enable ACPI-based enumeration for android pipe Alan
2016-01-25 22:56 ` [PATCH 0/8] Goldfish: partial resync with Google tree Kees Cook
2016-01-25 23:55   ` Greg Kroah-Hartman
     [not found] <1448413812-24289-1-git-send-email-jinqian@android.com>
2015-11-25  1:10 ` [PATCH 1/8] goldfish: refactor goldfish platform configs Jin Qian
2015-11-25 12:32   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160106140400.3661.13261.stgit@localhost.localdomain \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox