From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbcAFOFh (ORCPT ); Wed, 6 Jan 2016 09:05:37 -0500 Received: from down.free-electrons.com ([37.187.137.238]:54370 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752015AbcAFOFe (ORCPT ); Wed, 6 Jan 2016 09:05:34 -0500 Date: Wed, 6 Jan 2016 15:05:31 +0100 From: Maxime Ripard To: Mark Rutland Cc: Vishnu Patekar , robh+dt@kernel.org, corbet@lwn.net, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, emilio@elopez.com.ar, linus.walleij@linaro.org, jenskuske@gmail.com, hdegoede@redhat.com, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-gpio@vger.kernel.org Subject: Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Message-ID: <20160106140531.GK11722@lukather> References: <1452085914-29340-1-git-send-email-vishnupatekar0510@gmail.com> <1452085914-29340-3-git-send-email-vishnupatekar0510@gmail.com> <20160106132505.GJ563@leverpostej> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xb8pJpF45Qg/t7GZ" Content-Disposition: inline In-Reply-To: <20160106132505.GJ563@leverpostej> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Xb8pJpF45Qg/t7GZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mark, On Wed, Jan 06, 2016 at 01:25:05PM +0000, Mark Rutland wrote: > > + clocks { > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > + ranges; > > + > > + osc24M: osc24M_clk { > > + #clock-cells =3D <0>; > > + compatible =3D "fixed-clock"; > > + clock-frequency =3D <24000000>; > > + clock-output-names =3D "osc24M"; > > + }; > > + > > + osc32k: osc32k_clk { > > + #clock-cells =3D <0>; > > + compatible =3D "fixed-clock"; > > + clock-frequency =3D <32768>; > > + clock-output-names =3D "osc32k"; > > + }; > > + }; >=20 > Just put the clocks under the root node. 'clocks' is not a special > node. No, it's not a special node, but it's a very convenient one. It avoids "crippling" the main SoC definition with all the clocks definition, and keep the noise relatively low. And a bunch of other maintainers seem to agree: $ git grep "clocks {" -- arch/arm/boot/dts/ arch/arm64/boot/dts/ | wc -l 271 Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --Xb8pJpF45Qg/t7GZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWjR8rAAoJEBx+YmzsjxAgO5wP/3/dM4S1qoNxNrtL3UtX596h gt6vIv9seFwoEZOBTONH0+w5pQHlRDSn6mTIm3UJxAgNbq96B05OptItXA/2iA/T oS6eSdft+dVntmY0HwZ9ionTiKwTJwf9dG6D3z3oYQkHYy5TqzVL65k56ZEb3hmc YYXKPG8npcMfKyfCaWtBf9pjUKsoLjb/blPa6h8v9FtGUm+qAsYt0q8kmSPqP1tg IfKSb7Yr1oX/fjd+cjwFePzSHbeJoKl5ZfUU2qv9aOrW3So2izXjm40Efhcm91C7 6ASDasHRtPBti9E7jYSj1CTvOpvxaUu8WErniXAvA754F67ofUmolVvnBMOS1j6d YG5PrdW/LsHQ+pT9SIzSFGs87lJ5RgMwf/7O0g/CvDTvFrpxAvBDR3Wr4e58dh2L UjBuM9Y+rkZbYqllM1FgocTLHAl8L0AHRBLK67E30k55zoSz/mo2OCbOHFSdcMFp GTGxRlyTmRzgQVCMUm48pS0gL38ukH9n+SdnBBJIdYg1Dw8eOfEw6MPIWT67HYED 6fgD86+FHqQda3wf0vxMNOCLWYLK0UOkvR8Qs0g8N0VEJilBdEpARqjpvH92XdaV +Maoi3gJODlI3UqPEd1j4FNOvM2Y0H28ulDD5qLu6TRhsje0biXcH3aYwp3/ZX0J ajLxF/QF/vGXoLK067Pd =PmEu -----END PGP SIGNATURE----- --Xb8pJpF45Qg/t7GZ--