From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbcAFNZF (ORCPT ); Wed, 6 Jan 2016 08:25:05 -0500 Received: from down.free-electrons.com ([37.187.137.238]:53928 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751930AbcAFNZA (ORCPT ); Wed, 6 Jan 2016 08:25:00 -0500 Date: Wed, 6 Jan 2016 14:24:57 +0100 From: Boris Brezillon To: Rob Herring Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc Message-ID: <20160106142457.28c8af15@bbrezillon> In-Reply-To: <20160106131959.GA18121@rob-hp-laptop> References: <1452079551-30914-1-git-send-email-boris.brezillon@free-electrons.com> <1452079551-30914-2-git-send-email-boris.brezillon@free-electrons.com> <20160106131959.GA18121@rob-hp-laptop> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Wed, 6 Jan 2016 07:19:59 -0600 Rob Herring wrote: > On Wed, Jan 06, 2016 at 12:25:51PM +0100, Boris Brezillon wrote: > > Add Sil9022 DT bindings description. > > > > Signed-off-by: Boris Brezillon > > --- > > .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt > > new file mode 100644 > > index 0000000..7f1339f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt > > @@ -0,0 +1,31 @@ > > +sil902x HDMI bridge bindings > > + > > +Required properties: > > + - compatible: "sil,sil9022" > > + - reg: i2c address of the bridge > > + - reset-gpios: OF device-tree gpio specification for RST_N pin. > > + > > +Optional properties: > > + - interrupts-extended or interrupt-parent + interrupts: describe > > + the interrupt line used to inform the host about hotplug events. > > + > > +Optional subnodes: > > + - video input: Device node can contain video input port node to > > + connect the bridge to a display controller output (See this > > + documentation [1]). > > + > > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > > + > > +Example: > > + hdmi-bridge@39 { > > + compatible = "sil,sil9022"; > > + reg = <0x39>; > > + reset-gpios = <&gpx1 5 1 0 0>; > > 4 GPIO cells? Valid, but unusual. Hehe, I blindly copied nxp,ptn3460 doc, which is defining such GPIO descriptors :-). I can change that if you want. > > > + ports { > > + port@0 { > > Either need a reg property here or drop the unit address. You could > remove ports as well. Actually we'll likely define a 2nd port for the audio input, so I'd prefer keeping the ports and @0 suffix and adding a reg property rather than just defining port { ... }; Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com