From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752490AbcAFPFs (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jan 2016 10:05:48 -0500
Received: from mail.kernel.org ([198.145.29.136]:46399 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752422AbcAFPFq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jan 2016 10:05:46 -0500
Date: Wed, 6 Jan 2016 12:05:41 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Andi Kleen <andi@firstfloor.org>,
        Ulrich Drepper <drepper@gmail.com>, Will Deacon <will.deacon@arm.com>,
        Stephane Eranian <eranian@google.com>, Don Zickus <dzickus@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Liang, Kan" <kan.liang@intel.com>
Subject: Re: [PATCHv9 0/3] perf stat: Add scripting support
Message-ID: <20160106150541.GB10415@kernel.org>
References: <1452077397-31958-1-git-send-email-jolsa@kernel.org>
 <20160106141802.GA10415@kernel.org>
 <20160106143853.GA6431@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160106143853.GA6431@krava.brq.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Jan 06, 2016 at 03:38:53PM +0100, Jiri Olsa escreveu:
> On Wed, Jan 06, 2016 at 11:18:02AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jan 06, 2016 at 11:49:54AM +0100, Jiri Olsa escreveu:
> > > hi,
> > > sending another version of stat scripting.
> >  
> > > v9 changes:
> > >   - rebased on top of accepted patches
> > >   - desribed CPI metric in changelog [Arnaldo]
> > >   - fixed cpu conversion [Arnaldo]
> > 
> > Thanks, applied. Testing the cpi script with an endless:
> > 
> > perf stat record -I 1000 -a | perf script -s ~acme/git/linux/tools/perf/scripts/python/stat-cpi.py
> >      187.151796: cpu -1, thread -1 -> cpi 0.797917 (2568467461/3218963700)
> >      188.151979: cpu -1, thread -1 -> cpi 0.734628 (2714373371/3694892981)
> >      189.152212: cpu -1, thread -1 -> cpi 0.753332 (2958819204/3927644236)
> >      190.152975: cpu -1, thread -1 -> cpi 1.587754 (202360895/127451009)
> >      191.153486: cpu -1, thread -1 -> cpi 1.558219 (290557309/186467579)
> > 
> > in one monitor while trying various workloads in another, to see how it reacts,
> > and after a while those raw numbers at the end of each line become just noise,
> > I think they should be shown only under 'stat-cpy -v' (I think we can pass args
> > to the 'perf script' scripts, right?
> > 
> > Also the 'cpu', 'thread' and '-> cpi' could be turned into headers, like 'perf
> > stat' does?
> > 
> > Anyway, you called it 'example script' and we can improve it on top of what I
> > pushed to perf/core, i.e. this patchkit, unchanged, thanks!
> 
> yep, it's just noise and it's just an example to show

Hey, its not "just noise", I meant just the "(2568467461/3218963700)"
part at the end of each line and the repetitive cpu/thread/cpi stuff
that can be moved to the first line, as headers.

> how the stat scripting works.. we can tune it up with
> more ratios ;-)
> 
> jirka