From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Andi Kleen <andi@firstfloor.org>,
Ulrich Drepper <drepper@gmail.com>,
Will Deacon <will.deacon@arm.com>,
Stephane Eranian <eranian@google.com>,
Don Zickus <dzickus@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Liang, Kan" <kan.liang@intel.com>
Subject: Re: [PATCHv9 0/3] perf stat: Add scripting support
Date: Wed, 6 Jan 2016 16:39:16 +0100 [thread overview]
Message-ID: <20160106153916.GA12706@krava.brq.redhat.com> (raw)
In-Reply-To: <20160106150541.GB10415@kernel.org>
On Wed, Jan 06, 2016 at 12:05:41PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jan 06, 2016 at 03:38:53PM +0100, Jiri Olsa escreveu:
> > On Wed, Jan 06, 2016 at 11:18:02AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Jan 06, 2016 at 11:49:54AM +0100, Jiri Olsa escreveu:
> > > > hi,
> > > > sending another version of stat scripting.
> > >
> > > > v9 changes:
> > > > - rebased on top of accepted patches
> > > > - desribed CPI metric in changelog [Arnaldo]
> > > > - fixed cpu conversion [Arnaldo]
> > >
> > > Thanks, applied. Testing the cpi script with an endless:
> > >
> > > perf stat record -I 1000 -a | perf script -s ~acme/git/linux/tools/perf/scripts/python/stat-cpi.py
> > > 187.151796: cpu -1, thread -1 -> cpi 0.797917 (2568467461/3218963700)
> > > 188.151979: cpu -1, thread -1 -> cpi 0.734628 (2714373371/3694892981)
> > > 189.152212: cpu -1, thread -1 -> cpi 0.753332 (2958819204/3927644236)
> > > 190.152975: cpu -1, thread -1 -> cpi 1.587754 (202360895/127451009)
> > > 191.153486: cpu -1, thread -1 -> cpi 1.558219 (290557309/186467579)
> > >
> > > in one monitor while trying various workloads in another, to see how it reacts,
> > > and after a while those raw numbers at the end of each line become just noise,
> > > I think they should be shown only under 'stat-cpy -v' (I think we can pass args
> > > to the 'perf script' scripts, right?
> > >
> > > Also the 'cpu', 'thread' and '-> cpi' could be turned into headers, like 'perf
> > > stat' does?
> > >
> > > Anyway, you called it 'example script' and we can improve it on top of what I
> > > pushed to perf/core, i.e. this patchkit, unchanged, thanks!
> >
> > yep, it's just noise and it's just an example to show
>
> Hey, its not "just noise", I meant just the "(2568467461/3218963700)"
> part at the end of each line and the repetitive cpu/thread/cpi stuff
> that can be moved to the first line, as headers.
yep, thats what I meant as well
jirka
prev parent reply other threads:[~2016-01-06 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 10:49 [PATCHv9 0/3] perf stat: Add scripting support Jiri Olsa
2016-01-06 10:49 ` [PATCH 1/3] perf tools: Fix cpu conversion in cpu_map__from_entries Jiri Olsa
2016-01-09 16:31 ` [tip:perf/core] perf cpumap: " tip-bot for Jiri Olsa
2016-01-06 10:49 ` [PATCH 2/3] perf script: Display stat events by default Jiri Olsa
2016-01-09 16:31 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-06 10:49 ` [PATCH 3/3] perf script: Add stat-cpi.py script Jiri Olsa
2016-01-09 16:32 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-06 14:18 ` [PATCHv9 0/3] perf stat: Add scripting support Arnaldo Carvalho de Melo
2016-01-06 14:38 ` Jiri Olsa
2016-01-06 15:05 ` Arnaldo Carvalho de Melo
2016-01-06 15:39 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106153916.GA12706@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=drepper@gmail.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox