From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbcAFXzJ (ORCPT ); Wed, 6 Jan 2016 18:55:09 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34588 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbcAFXzF (ORCPT ); Wed, 6 Jan 2016 18:55:05 -0500 Date: Wed, 6 Jan 2016 15:55:01 -0800 From: Dmitry Torokhov To: Hans de Goede Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Santiago Gala , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Hung Subject: Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol Message-ID: <20160106235501.GA3129@dtor-ws> References: <1427031971-13018-1-git-send-email-pali.rohar@gmail.com> <20160105164421.GP22661@pali> <568CCC6E.7010707@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <568CCC6E.7010707@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2016 at 09:12:30AM +0100, Hans de Goede wrote: > Hi, > > On 05-01-16 17:44, Pali Rohár wrote: > >On Sunday 22 March 2015 14:46:11 Pali Rohár wrote: > >>This patch adds detection of trackstick for v7 protocol devices. Code in this > >>patch is used in official Dell touchpad linux drivers for Dell models: > >>Dell Latitude E5250/5250, E5450/5450, E5550/5550 > >> > >>Detection code and base reg for alps v3 rushmore and v7 devices is exacly same. > >> > >>Also user in bug https://bugzilla.kernel.org/show_bug.cgi?id=94801 reported > >>that Toshiba Sattellite Z30-A-1DG has only alps v7 touchpad device without > >>trackstick and kernel reports to userspace also redundant trackstick device. > >> > >>Signed-off-by: Pali Rohár > >>--- > > > >Hello! > > > >Alex now tested this patch on two Dell machines with ALPS: E5450 (with > >TrackStick) and E5250 (without TrackStick). > > > >With patch nothing was changed for E5450. And E5250 with patch does not > >show trackstick input device anymore. > > > >Tested-by: Alex Hung > > With that this patch looks good to me: > > Reviewed-by: Hans de Goede > > Pali, it is probably a good idea to send Dmitry a v2 of these 2 > patches rebased on top of the latest next and with Alex' Tested-By > and my Reviewed-by-s added. It's alright, I added the tags and applied. -- Dmitry