From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbcAGAER (ORCPT ); Wed, 6 Jan 2016 19:04:17 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34202 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbcAGAEN (ORCPT ); Wed, 6 Jan 2016 19:04:13 -0500 Date: Wed, 6 Jan 2016 16:04:10 -0800 From: Brian Norris To: Robert Jarzmik Cc: Ezequiel Garcia , Ezequiel Garcia , David Woodhouse , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Message-ID: <20160107000410.GR109450@google.com> References: <1439323034-8820-1-git-send-email-robert.jarzmik@free.fr> <20150818042426.GA27858@laptop> <874mjwa1w6.fsf@belgarion.home> <87r3mt3jpw.fsf@belgarion.home> <20151219004845.GW10460@google.com> <87lh8qhbqp.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lh8qhbqp.fsf@belgarion.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 19, 2015 at 01:19:26PM +0100, Robert Jarzmik wrote: > Brian Norris writes: > > > I don't have very strong opinions on this. It's kind of annoying to have > > this sort of stuff duplicated for every driver, if it's really needed. > > But I'll admit this kind of infrastructure is sometimes useful. > > > > Anecdote: I recently found the regmap trace event infrastructure pretty > > nice for debugging some other drivers. This would only require you to > > have tracing enabled, and then no recompiles are necessary at all. Just > > cmdline changes. > > > > So, I could go with this patch, if Robert still desires it. Or you could > > convert to using regmap for MMIO :) > I'm as you, I don't feel strong opinion about it, I'd like to have a debug > tracing tool, be that this patch or regmap MMIO. Regmap is probably overkill, and wouldn't do a lot to satisfy Ezequiel's concern, I expect. > If we all agree on a path I could even make the final patch, whichever solution > is chosen. I'm OK with this one, which still applies OK for me. But I do have one comment, which I'll post at the top-level. Brian