From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752575AbcAGAID (ORCPT ); Wed, 6 Jan 2016 19:08:03 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:43524 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbcAGAH6 (ORCPT ); Wed, 6 Jan 2016 19:07:58 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.150 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 7 Jan 2016 09:07:26 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo CC: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Steven Rostedt , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: Re: [PATCH v3 3/5] perf tools: Fix dynamic sort keys to sort properly Message-ID: <20160107000726.GF8053@sejong> References: <1452041701-27689-1-git-send-email-namhyung@kernel.org> <1452041701-27689-3-git-send-email-namhyung@kernel.org> <20160106230643.GB2012@kernel.org> <20160106232645.GC8053@sejong> <20160106233149.GE2012@kernel.org> <20160106235045.GF2012@kernel.org> MIME-Version: 1.0 In-Reply-To: <20160106235045.GF2012@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/07 09:07:26, Serialize by Router on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/07 09:07:26, Serialize complete at 2016/01/07 09:07:26 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2016 at 08:50:45PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 06, 2016 at 08:31:49PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Jan 07, 2016 at 08:26:45AM +0900, Namhyung Kim escreveu: > > > On Wed, Jan 06, 2016 at 08:06:43PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Wed, Jan 06, 2016 at 09:54:59AM +0900, Namhyung Kim escreveu: > > > > > Currently, the dynamic sort keys compares trace data using memcmp(). > > > > > But for output sorting, it should check data size and compare by word. > > > > > Also it sorted strings in reverse order, fix it. > > > > > > > > Can this be broken down in two patches? This is complex code, lets try > > > > to make it as bisectable as possible. > > > > > > OK, I'll break out the string part then. But I think it doesn't help > > > much to reduce the complexity. > > > > Well, number of patches is not a problem, everytime I see a "Also lets > > do this other thing" I cringe, it is automatic, sorry :-\ > > > > For reviewing its soooo much better to see things nicely separated, and > > sometimes I like one part but not the other, so I pick one and continue > > discussion on the other, etc. > > Ah, please rebase from my latest perf/core, I'm still holding on it > since some 'perf test' entries are failing and I want to check first if > its due to bugs introduced in this branch... Will do! Thanks, Namhyung