From: Dave Jones <davej@codemonkey.org.uk>
To: Linux Kernel <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: weird DirectMap2M accounting.
Date: Wed, 6 Jan 2016 19:18:50 -0500 [thread overview]
Message-ID: <20160107001850.GA7443@codemonkey.org.uk> (raw)
In-Reply-To: <20160107001141.GA6595@codemonkey.org.uk>
On Wed, Jan 06, 2016 at 07:11:41PM -0500, Dave Jones wrote:
> On Wed, Jan 06, 2016 at 06:55:27PM -0500, Dave Jones wrote:
> > I just spotted this in /proc/meminfo on an old Core2 machine with 4G.
> >
> > DirectMap2M: 18446744073709543424 kB
> >
> > Looks like we subtracted 8192 from 0 somewhere.
> >
> > Should split_page_count() be checking that direct_pages_count > 0 ?
>
> Ok, this diff makes that number print out as 0.
>
> If this looks ok, I'll submit it properly, though I'd like to better
> understand what's happening here. Shouldn't I have 2M pages ?
Ah. We disable them when compiling with DEBUG_PAGEALLOC.
So this is only needed in that case.
If people think it's worth an ifdef for those two added lines I'll add it,
but it seems pretty benign to just always check.
thoughts?
Dave
next prev parent reply other threads:[~2016-01-07 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 23:55 weird DirectMap2M accounting Dave Jones
2016-01-07 0:11 ` Dave Jones
2016-01-07 0:18 ` Dave Jones [this message]
2016-01-11 8:58 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107001850.GA7443@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox