From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752889AbcAGKuW (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jan 2016 05:50:22 -0500
Received: from mail-pa0-f52.google.com ([209.85.220.52]:34198 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752849AbcAGKuS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jan 2016 05:50:18 -0500
Date: Thu, 7 Jan 2016 19:49:24 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <andi@firstfloor.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Wang Nan <wangnan0@huawei.com>
Subject: Re: [RFC/PATCH v2] perf report: Show random usage tip on the help
 line
Message-ID: <20160107104924.GC5499@danjae.kornet>
References: <1452152782-26892-1-git-send-email-namhyung@kernel.org>
 <20160107080320.GB20434@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160107080320.GB20434@krava.brq.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 07, 2016 at 09:03:20AM +0100, Jiri Olsa wrote:
> On Thu, Jan 07, 2016 at 04:46:22PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > +const char *perf_report_tip(const char *dirname)
> > +{
> > +	struct strlist *tips;
> > +	struct str_node *node;
> > +	char *tip = NULL;
> > +	struct strlist_config conf = {
> > +		.dirname = system_path(dirname) ,
> > +	};
> > +
> > +	tips = strlist__new("tips.txt", &conf);
> > +	if (tips == NULL || strlist__nr_entries(tips) == 1) {
> > +		tip = (char *)"Cannot find tips.txt file";
> > +		goto out;
> > +	}
> > +
> > +	node = strlist__entry(tips, random() % strlist__nr_entries(tips));
> > +	if (asprintf(&tip, "Tip: %s", node->s) < 0)
> > +		tip = (char *)"Not enough memory";
> 
>                 ^^^ this could be tip = (char *) "Tip: get more memory!";  ;-)

Haha.  Will change. :)

Thanks,
Namhyung