From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbcAGLNf (ORCPT ); Thu, 7 Jan 2016 06:13:35 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35322 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbcAGLNc (ORCPT ); Thu, 7 Jan 2016 06:13:32 -0500 Date: Thu, 7 Jan 2016 20:12:39 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Peter Zijlstra , Noel Grandin , Adrian Hunter Subject: Re: [PATCH 06/13] perf record: Store data mmaps for dwarf unwind Message-ID: <20160107111239.GE5499@danjae.kornet> References: <1452158050-28061-1-git-send-email-jolsa@kernel.org> <1452158050-28061-7-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452158050-28061-7-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 10:14:03AM +0100, Jiri Olsa wrote: > Currently we don't synthesize data mmap by default. It depends > on -d option, that enables data address sampling. > > But we've seen cases (softice) where DWARF unwinder went through > non executable mmaps, which we need to lookup in MAP__VARIABLE tree. > > Making data mmaps to be synthesized for dwarf unwind as well. > > Reported-by: Noel Grandin > Link: http://lkml.kernel.org/n/tip-lh02yir6qfycn8zr892rmlgg@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-record.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 9c5cdc2c4471..920b93edb497 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -804,6 +804,7 @@ int record_parse_callchain_opt(const struct option *opt, > int ret; > struct record_opts *record = (struct record_opts *)opt->value; > > + record->sample_address = true; It seems unconditionally set, no? Thanks, Namhyung > record->callgraph_set = true; > callchain_param.enabled = !unset; > > -- > 2.4.3 >