From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928AbcAGMeQ (ORCPT ); Thu, 7 Jan 2016 07:34:16 -0500 Received: from 8bytes.org ([81.169.241.247]:50747 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbcAGMeO (ORCPT ); Thu, 7 Jan 2016 07:34:14 -0500 Date: Thu, 7 Jan 2016 13:34:12 +0100 From: Joerg Roedel To: Suravee Suthikulpanit Cc: bp@alien8.de, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters Message-ID: <20160107123411.GH19149@8bytes.org> References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-3-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451672020-2150-3-git-send-email-Suravee.Suthikulpanit@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote: > Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, > which should not be the case. Also, these don't properly support > multi-IOMMU system. > > Current and future AMD systems with IOMMU that support perf counter > would likely contain homogeneous IOMMUs where multiple IOMMUs are > availalbe. So, this patch modifies these function to iterate all IOMMU > to check the max banks and counters reported by the hardware. > > Signed-off-by: Suravee Suthikulpanit > --- > arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++---------- > drivers/iommu/amd_iommu_init.c | 20 ++++++++++++-------- > include/linux/perf/perf_event_amd_iommu.h | 7 ++----- > 3 files changed, 21 insertions(+), 23 deletions(-) Reviewed-by: Joerg Roedel This looks like the fix for the CZ issue, right? If true, it is probably v4.5 material.