From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753417AbcAGPmZ (ORCPT ); Thu, 7 Jan 2016 10:42:25 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:33109 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbcAGPmW (ORCPT ); Thu, 7 Jan 2016 10:42:22 -0500 Date: Thu, 7 Jan 2016 10:42:18 -0500 From: Tejun Heo To: Parav Pandit Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, lizefan@huawei.com, Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Haggai Eran , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Matan Barak , raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org Subject: Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller. Message-ID: <20160107154218.GF29797@mtj.duckdns.org> References: <1452020286-9508-1-git-send-email-pandit.parav@gmail.com> <1452020286-9508-7-git-send-email-pandit.parav@gmail.com> <20160105215309.GG5995@mtj.duckdns.org> <20160106225714.GI3660@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jan 07, 2016 at 05:22:40AM +0530, Parav Pandit wrote: > I can remove "resource" key word. If just that if something other than > resource comes up to limit to in future, it will be hard to define at > that time. Please remove. The word doesn't mean anything in this context. > > Also can't the .max file list > > the available resources? Why does it need a separtae list file? > > > max file does lists them only after limits are configured for that > device. Thats when rpool (array of max and usage counts) is allocated. > > If user wants to know what all knobs are available, than list file > exposes them on per device basis without actually mentioning actual > limit or without allocating rpool arrays. ... > list file looks like below for two device entries. > mlx4_0 ah qp mr pd srq flow > ocrdma0 ah qp mr pd > > max file looks like below. > mlx4_0 ah=100 qp=40 mr=10 pd=90 srq=10 flow=10 Just always show the settings for all devices in the max file like the following? mlx4_0 ah=max qp=max mr=max pd=max srq=max flow=max ocrdma0 ah=max qp=max mr=max pd=max Thanks. -- tejun