[PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style

[PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style

[Pranjal Bhor]

Blank line after opening brace removed

Signed-off-by: Pranjal Bhor <bhor.pranjal@gmail.com>
---
 drivers/staging/wlan-ng/p80211conv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index 1b02cdf..7e3d4b5 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -106,7 +106,6 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,
			struct sk_buff *skb, union p80211_hdr *p80211_hdr,
			struct p80211_metawep *p80211_wep)
 {
-
	__le16 fc;
	u16 proto;
	struct wlan_ethhdr e_hdr;
--
1.9.1

Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style

[Greg KH]

On Fri, Jan 08, 2016 at 12:44:15AM +0530, Pranjal Bhor wrote:
> Blank line after opening brace removed
> 
> Signed-off-by: Pranjal Bhor <bhor.pranjal@gmail.com>
> ---
>  drivers/staging/wlan-ng/p80211conv.c | 1 -
>  1 file changed, 1 deletion(-)

I can't take 40 patches all with the exact same Subject: :(

Please make them unique, as-is, this isn't acceptable.

sorry,

greg k-h

Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style

[Greg KH]

On Thu, Jan 07, 2016 at 11:21:13AM -0800, Greg KH wrote:
> On Fri, Jan 08, 2016 at 12:44:15AM +0530, Pranjal Bhor wrote:
> > Blank line after opening brace removed
> > 
> > Signed-off-by: Pranjal Bhor <bhor.pranjal@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/p80211conv.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> I can't take 40 patches all with the exact same Subject: :(
> 
> Please make them unique, as-is, this isn't acceptable.

Also, this shouldn't be one-patch-per-fix, it's
one-patch-per-type-of-fix.  This can be reduced to many less patches.

thanks,

greg k-h

Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style

[Dan Carpenter]

You can't have 40 patches with the same subject.  Also that is too
generic a subject.

Also don't break it up into one line per patch, break it up so it's
patch 1: remove blank lines
patch 2: no spaces after a cast
patch 3: fix all NULL compares

etc...

regards,
dan carpenter