* [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style
@ 2016-01-07 19:14 Pranjal Bhor
2016-01-07 19:21 ` Greg KH
2016-01-07 21:55 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Pranjal Bhor @ 2016-01-07 19:14 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Pranjal Bhor
Blank line after opening brace removed
Signed-off-by: Pranjal Bhor <bhor.pranjal@gmail.com>
---
drivers/staging/wlan-ng/p80211conv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index 1b02cdf..7e3d4b5 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -106,7 +106,6 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,
struct sk_buff *skb, union p80211_hdr *p80211_hdr,
struct p80211_metawep *p80211_wep)
{
-
__le16 fc;
u16 proto;
struct wlan_ethhdr e_hdr;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style
2016-01-07 19:14 [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style Pranjal Bhor
@ 2016-01-07 19:21 ` Greg KH
2016-01-07 19:21 ` Greg KH
2016-01-07 21:55 ` Dan Carpenter
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-01-07 19:21 UTC (permalink / raw)
To: Pranjal Bhor; +Cc: devel, linux-kernel
On Fri, Jan 08, 2016 at 12:44:15AM +0530, Pranjal Bhor wrote:
> Blank line after opening brace removed
>
> Signed-off-by: Pranjal Bhor <bhor.pranjal@gmail.com>
> ---
> drivers/staging/wlan-ng/p80211conv.c | 1 -
> 1 file changed, 1 deletion(-)
I can't take 40 patches all with the exact same Subject: :(
Please make them unique, as-is, this isn't acceptable.
sorry,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style
2016-01-07 19:21 ` Greg KH
@ 2016-01-07 19:21 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-01-07 19:21 UTC (permalink / raw)
To: Pranjal Bhor; +Cc: devel, linux-kernel
On Thu, Jan 07, 2016 at 11:21:13AM -0800, Greg KH wrote:
> On Fri, Jan 08, 2016 at 12:44:15AM +0530, Pranjal Bhor wrote:
> > Blank line after opening brace removed
> >
> > Signed-off-by: Pranjal Bhor <bhor.pranjal@gmail.com>
> > ---
> > drivers/staging/wlan-ng/p80211conv.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> I can't take 40 patches all with the exact same Subject: :(
>
> Please make them unique, as-is, this isn't acceptable.
Also, this shouldn't be one-patch-per-fix, it's
one-patch-per-type-of-fix. This can be reduced to many less patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style
2016-01-07 19:14 [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style Pranjal Bhor
2016-01-07 19:21 ` Greg KH
@ 2016-01-07 21:55 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-07 21:55 UTC (permalink / raw)
To: Pranjal Bhor; +Cc: gregkh, devel, linux-kernel
You can't have 40 patches with the same subject. Also that is too
generic a subject.
Also don't break it up into one line per patch, break it up so it's
patch 1: remove blank lines
patch 2: no spaces after a cast
patch 3: fix all NULL compares
etc...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-07 21:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 19:14 [PATCH 01/40] drivers/stagin/wlan-ng/p80211conv.c: Fix coding style Pranjal Bhor
2016-01-07 19:21 ` Greg KH
2016-01-07 19:21 ` Greg KH
2016-01-07 21:55 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox