From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932072AbcAHIfw (ORCPT ); Fri, 8 Jan 2016 03:35:52 -0500 Received: from verein.lst.de ([213.95.11.211]:50285 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbcAHIfu (ORCPT ); Fri, 8 Jan 2016 03:35:50 -0500 Date: Fri, 8 Jan 2016 09:35:47 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , "Nicholas A. Bellinger" , target-devel , linux-scsi , lkml , Sagi Grimberg , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham , Nicholas Bellinger Subject: Re: [PATCH 1/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl Message-ID: <20160108083547.GA32501@lst.de> References: <1452237348-2277-1-git-send-email-nab@daterainc.com> <1452237348-2277-2-git-send-email-nab@daterainc.com> <20160108081412.GA32138@lst.de> <568F73D2.2090808@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568F73D2.2090808@sandisk.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 09:31:14AM +0100, Bart Van Assche wrote: > Indeed. All error paths in all target drivers will have to be modified to > avoid that an acl reference leak is triggered if transport_init_session() > fails after core_tpg_check_initiator_node_acl() succeeded. I'm still hoping for a nice helper that does transport_init_session + core_tpg_check_initiator_node_acl + transport_register_session to isolated all that. It might need a callout to the driver somewhere to be flexible enough but still would be a huge win..