From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932157AbcAHLNn (ORCPT ); Fri, 8 Jan 2016 06:13:43 -0500 Received: from mail-bn1bon0069.outbound.protection.outlook.com ([157.56.111.69]:45629 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932140AbcAHLNh (ORCPT ); Fri, 8 Jan 2016 06:13:37 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Fri, 8 Jan 2016 14:13:18 +0300 From: Yury Norov To: Arnd Bergmann CC: , , , , , , , , , , , , , , , , Andrew Pinski , Andrew Pinski Subject: Re: [PATCH v6 14/21] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160108111318.GA24066@yury-N73SV> References: <1452209679-19445-1-git-send-email-ynorov@caviumnetworks.com> <1452209679-19445-15-git-send-email-ynorov@caviumnetworks.com> <8354919.jOyEk0znB5@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8354919.jOyEk0znB5@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: HE1PR06CA0061.eurprd06.prod.outlook.com (25.164.28.157) To DM2PR07MB624.namprd07.prod.outlook.com (10.141.177.154) X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB624;2:cgiRjC6DmUyZYTZaGdi9pniwbn6LdJI4yY/f5zo0iJuDfcJ92cZolQqUD99gkkDECtvIuCsyfeJi3zjYGgfMMNJRYhXttH/kW4xoIoCZyRxQZdDPKkqs0xv1Glrp6wuTQVNgCuDm+rZxUMJWRe6P8Q==;3:WH8zk7vAhc0kzCxEcW18pvLdj5uNckzUTnmKB1y5/3XbQzmvds+v/zhdyAZKw38TONRf3YivEwdU6uVMkmr9LiUsXfDzzPl9Ft4IOW4yIlVJmM6zDUPMvszecgFDyM3D;25:MVD4V0+iU2pgzdYc6wfBU0HTOHAqIxv80nqeX+aL+gWmF8FYnvEqbn3cN06vx3X3s5zzucqdn0Zz+W1Ki42JAPIItnnyh+pRn9E34pO2h9lldoC0qZv78Omfr6MPY5YP+CC4MHLyV80XwlYm695yDDag86YCqf4yU5I8zRNcnq9dNlfLldMZKFvJ08KwgIh3oy177FcGMDeRYUXwHeTNQEfz+HkCDKvlcqWSEaHJdvBYgfQmFrq+/PL6KGlQQbyH X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB624; X-MS-Office365-Filtering-Correlation-Id: a46cdb06-23fd-491b-9aaa-08d3181cbe5e X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB624;20:EYgVRWMFmjDC22f6MDRA5ecw6KVVDiA+wtVnbH8Haw+K8jdNZCVg+HqYbAIRGkT30rlZqoMOBG9rKj3ZxnF9GftIihUnZ6ZJSNwopsOfXUiI+phaK8Asb55op/lx83/VPNJReiugVXpzKrUpr0BjVXBT2jpcOi6ruQ38wb8MUYz3IUx9YUrqOrd1tn3KvbX+zSj1X2mgWV3A9DNpB1I+JCXEW0+4sz8CWRjUOkyuJ8IihqMgQxe5PO4JG5h8x9c6x9Rcx2pvQ8G4zFCWr5vQnVyZoHMUcQ2JquABzKB580xFY1wUp8JhNufNVCz9SH9brRmZyiIzZnHz4E6l6rjqV2KtRCSdER5zHAQnq+cMMYivyGFpBulERs5qNDZ8Ywmwo6pohyzTI4DW7TGh0DqkNS6DogANyBPvPN761/Pbpw4XsAhA2CQiXlGdeHpJWxTmCxcGdNb6qL/qJxIZxqL5bPgeLF0W+345ir0mzhG0/fNIiucaT+b4c+WG9DO2iZAEB8X7EyCBhKU9je8mOGfnKIy/sWhuIcqDSGqso1h3QdlCQ+uIBPOYZaULdHrZiP2gIiv5KPn/XoAmMopLejU02N6vyTeHkbjz867D9ZaVfsY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:DM2PR07MB624;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB624; X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB624;4:2jt2j1dUTqc4H8TKAh5jIo6cTZhOliMWs+Ha9rXLElBKHiOEib9sEKhGT2qQ/xc2BOqZI3B9TrWwR/VpX6xHKoKXUNpkyOU1PPJV8rAnuw6V0ezT3vrJREA53THxo8Vp+ImVhdV210DcDGfJ/tBVKHjFwr/c00huXQPn8RaQ4nKjD9YEvEKp+MUzOqF/vIRhD65c7I0OXsdYXzMF++BwkyiGOyUZSlTaa0P+wx8LELXgePNi0OvBBPwiYK1ovBGxO2GgNlocOmlW9J5ecZS8Zaf3ORIIuGMEhQf+CWwlABdpoG5hNKaLuPVDSPwifp9EiyCbxDw7IdejuqRrHxI3qZqqoyZGzAlth+AaAAxGD/ejQJxfMjsbf0T3Q42exSXc X-Forefront-PRVS: 0815F8251E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(199003)(24454002)(189002)(76176999)(54356999)(46406003)(50986999)(101416001)(83506001)(97756001)(47776003)(106356001)(2906002)(66066001)(87976001)(76506005)(105586002)(42186005)(107886002)(81156007)(5001960100002)(189998001)(4001350100001)(33716001)(77096005)(5008740100001)(40100003)(122386002)(586003)(4001430100002)(1096002)(1076002)(4326007)(92566002)(23726003)(97736004)(50466002)(2950100001)(5004730100002)(33656002)(110136002)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR07MB624;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR07MB624;23:hbPkgSom2WyX5lcB+h5JNL1T5zvIsqg+hy/jdRStd9?= =?us-ascii?Q?iFqRFIaoerXcu/tWOcNo9EAoBCpHGiG4j15LBKpumZo7s52Y02D9VXdC+xrF?= =?us-ascii?Q?SvHUoRz3TIFplrckMCXTVS3KCfoS2714XuaXFvlT6n9o3iZuJH+owwQ/FTRd?= =?us-ascii?Q?d3d55CiJOXR4FSvA8Zyt+9/n8Wu25jdq5ntQKBFFNUO41q/bJAsF4GMw/ed8?= =?us-ascii?Q?SuvIG73uBirk7VMf1ag7GSRox+wwViJkan/So0EcbRCHPcVNwyHIZwiLxP7f?= =?us-ascii?Q?KwaRKXuv3Jd4MpXADqmRyCyztg0jm8OmMl2blvzZAw8DlaUl5xz+m75NBWQR?= =?us-ascii?Q?tAu0cpUkjDRFb2YeLxE/TmaiT0V3cOOGNa1xdO/kwrqfFm0NC87kV5k0mWE7?= =?us-ascii?Q?C86yeLN9xQCsPnn/PwIpYPOFJegQY1HwdallvUnNjTOEQa9Megm/juZK3rAT?= =?us-ascii?Q?tXURs09cXroXY+CMT7Bg6ptu+wd19LZQhHtDwqK7ukIin/gNFycwakNFiwOV?= =?us-ascii?Q?Qv+oWTFi7WWnupjmUCuuFbQatC4OOqcT/AdNNFrG74H2RbdfqUeRNAv/CwL8?= =?us-ascii?Q?NWAdV4aGGHDN55F8VGVo2MJpRbJ8kBf+rw+Ab5eaArPwpm4F0BF0QJpx0d94?= =?us-ascii?Q?SoXqYVaLfJhqh8itEKkRNqLjfLpIjHJ+pADp2C6IC5Oo+Fze1hrhHuKsURcm?= =?us-ascii?Q?/0KHVqANZS0eLZRWwEloxzXOcOhZyZyfEYCGVzqqh6Iahw2RNuqV+tyyIsQ6?= =?us-ascii?Q?F6TRoz16yG3Jqr3l2yCBX8ydr6q04ov740wgV3/z0OfycWPp8MHbMbJUatTD?= =?us-ascii?Q?0D0H1Wogb0blvRJ2XaqTWfzyDi2Rx+5U4HlkdJwvOgRe1Kbi2K4/P/aWS6If?= =?us-ascii?Q?U5Pp7SF32T0HjDLx28hXEic2icEPmQFF4Z93NzhyU5pEnU63+KPtjcj+5qN7?= =?us-ascii?Q?butalQgh13Cg0G0RDmazm4TyPyNPbgqfSmL0h1gbJYWGu93HfvB6W9M+ttFr?= =?us-ascii?Q?bvvmHNB6ZQaPPfUZmOVwkyIFFmZzecp90uDX4ZI93726VLrm+5umTHqm8YDK?= =?us-ascii?Q?dMT9EEXEVAk+dFlJzDKCgEjd42Oy93zN0UhcZwx/1VAaz9ikmYFdclHhstka?= =?us-ascii?Q?K6SFI87ZVqjCkJd1UHOtXeoEf4R5FKKAT+jnHD64euMEAh20n8Uw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB624;5:lWAtqkb4+naqjo3yehB+uO6gsS+dS1ad7cuElfFST685Zu4X05ZoSOfdM+WscmP21i7r6//Mq+7N9McCsRcLU7vrEbLl4iYGE2ThTeC1W0f+qQYlVcsTdivn95fBaeomZgLADjrzcUQXb3tOmbH1Ww==;24:m1t0n+qtiJNfwGVG8HJFgTNkosnERVtAtdWJV3lz5GmL3ll0+2ehuGysBtkiIIuOFahzvJbxyweVEHtKM0/p8VdWAc+XCFGKi1fVanPhqzo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2016 11:13:31.6549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB624 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 10:21:06AM +0100, Arnd Bergmann wrote: > On Friday 08 January 2016 02:34:32 Yury Norov wrote: > > > @@ -688,6 +692,12 @@ ni_sys: > > b ret_fast_syscall > > ENDPROC(el0_svc) > > > > +#ifdef CONFIG_ARM64_ILP32 > > +el0_ilp32_svc: > > + adrp stbl, sys_call_ilp32_table // load syscall table pointer > > + b el0_svc_naked > > +#endif > > Don't we still need some code that clears the top halves of the 32-bit > arguments? That thread has taken so many turns now that I'm confused > about what we actually need, but I thought we had concluded that your > current approach has at some some problems. We are discussing how to do it better - make a generic solution from s390 with individual syscall handling, or reproduce s390 solution for ILP32, or zero top-half registers and not use top half of register at all. As I understand, we stand on 1st option, and agreed to introduce it separately. > > > +#include > > + > > +#undef __SYSCALL > > +#undef __SC_COMP > > +#undef __SC_3264 > > +#undef __SC_COMP_3264 > > The four #undef are not needed, right? > > Arnd