From: Chris Bainbridge <chris.bainbridge@gmail.com>
To: yann.morin.1998@free.fr
Cc: linux-kernel@vger.kernel.org, mmarek@suse.cz, bbarbulovski@gmail.com
Subject: [PATCH] kconfig: fix qconf segfault by deleting heap objects
Date: Fri, 8 Jan 2016 20:44:04 +0000 [thread overview]
Message-ID: <20160108204404.GA14615@localhost> (raw)
On Debian stable (qt-4.8.6) 'make xconfig' intermittently fails due to
qconf segfaulting at exit time in QXcbEventReader. The cause of this is
destructors on the heap objects never being called, so fix this by
properly deleting the heap objects before exit.
Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
---
Trivial error, as described at https://forum.qt.io/topic/26658/solved-segfault-on-qapplication-exit
---
scripts/kconfig/qconf.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 91b7e6fbc364..fc5555992220 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1863,6 +1863,8 @@ int main(int ac, char** av)
configSettings->endGroup();
delete configSettings;
+ delete v;
+ delete configApp;
return 0;
}
--
2.1.4
next reply other threads:[~2016-01-08 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 20:44 Chris Bainbridge [this message]
2016-01-11 8:46 ` [PATCH] kconfig: fix qconf segfault by deleting heap objects Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108204404.GA14615@localhost \
--to=chris.bainbridge@gmail.com \
--cc=bbarbulovski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).