From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755528AbcAHX3r (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jan 2016 18:29:47 -0500
Received: from mail-wm0-f47.google.com ([74.125.82.47]:38348 "EHLO
	mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754207AbcAHX3p (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jan 2016 18:29:45 -0500
Date: Sat, 9 Jan 2016 01:29:42 +0200
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Alexander Kuleshov <kuleshovmail@gmail.com>, Robin Holt <holt@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
        David Rientjes <rientjes@google.com>, Joonsoo Kim <js1304@gmail.com>,
        Yaowei Bai <bywxiaobai@163.com>, Xishi Qiu <qiuxishi@huawei.com>,
        Alexander Duyck <alexander.h.duyck@redhat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable
Message-ID: <20160108232942.GB13046@node.shutemov.name>
References: <1452239948-1012-1-git-send-email-kuleshovmail@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452239948-1012-1-git-send-email-kuleshovmail@gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
> This patch removes unused struct zone *z variable which is
> appeared in 86051ca5eaf5 (mm: fix usemap initialization)

I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
into a separate function).
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

> ---
>  mm/page_alloc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 9d666df..9bde098 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
>  	pg_data_t *pgdat = NODE_DATA(nid);
>  	unsigned long end_pfn = start_pfn + size;
>  	unsigned long pfn;
> -	struct zone *z;
>  	unsigned long nr_initialised = 0;
>  
>  	if (highest_memmap_pfn < end_pfn - 1)
>  		highest_memmap_pfn = end_pfn - 1;
>  
> -	z = &pgdat->node_zones[zone];
>  	for (pfn = start_pfn; pfn < end_pfn; pfn++) {
>  		/*
>  		 * There can be holes in boot-time mem_map[]s
> -- 
> 2.6.2.485.g1bc8fea
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
 Kirill A. Shutemov