From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754820AbcAIDhQ (ORCPT ); Fri, 8 Jan 2016 22:37:16 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:46916 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbcAIDhO (ORCPT ); Fri, 8 Jan 2016 22:37:14 -0500 Date: Sat, 9 Jan 2016 03:37:12 +0000 From: Al Viro To: Joshua Hudson Cc: linux-kernel Subject: Re: [PATCH] add support for larger files in minix filesystem Message-ID: <20160109033712.GA5955@ZenIV.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2015 at 07:56:36PM -0800, Joshua Hudson wrote: > From: Joshua Hudson > > The Minix v3 filesystem and kernel driver have no actual dependency on files > being less than 2GB in size; however the kernel does not allow creating a > file of 2GB or larger on a Minix v3 filesystem. I was able to remove the pseudo- > dependency easily by changing one line of code (filesystems need to tell VFS > how big of files they allow). Umm... AFAICS, native Minix v3 fsck will throw a fit if it sees anything between 2Gb and 4Gb and truncate the value. Seeing that it's their format _and_ silent changes like that (especially hidden by something like "you need to binary-patch the field at this offset in superblock first") are generally considered rude. I'd suggest you to talk to Minix folks and convince them to raise that limit; if it's merely a matter of unhappy fsck, it shouldn't be hard, but if their minix/mfs/*.c code would get unhappy on files longer than 2Gb, it would be harder and in that case we _really_ shouldn't run around creating such files there. Seriously, talk to Minix folks first.