From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757848AbcAJXwQ (ORCPT ); Sun, 10 Jan 2016 18:52:16 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:38483 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757663AbcAJXwP (ORCPT ); Sun, 10 Jan 2016 18:52:15 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.150 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Mon, 11 Jan 2016 08:54:09 +0900 From: Minchan Kim To: "Michael S. Tsirkin" CC: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Konstantin Khlebnikov , Rafael Aquini , stable@vger.kernel.org Subject: Re: [PATCH 2/2] virtio_balloon: fix race between migration and ballooning Message-ID: <20160110235409.GA7452@bbox> References: <1451259313-26353-1-git-send-email-minchan@kernel.org> <1451259313-26353-2-git-send-email-minchan@kernel.org> <20160101102756-mutt-send-email-mst@redhat.com> <20160104002747.GA31090@blaptop.local> <20160110233310-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20160110233310-mutt-send-email-mst@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/11 08:52:11, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/11 08:52:11, Serialize complete at 2016/01/11 08:52:11 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2016 at 11:40:17PM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 04, 2016 at 09:27:47AM +0900, Minchan Kim wrote: > > > I think this will cause deadlocks. > > > > > > pages_lock now nests within page lock, balloon_page_putback > > > nests them in the reverse order. > > > > In balloon_page_dequeu, we used trylock so I don't think it's > > deadlock. > > I went over this again and I don't see the issue anymore. > I think I was mistaken, so I dropped my patch and picked > up yours. Sorry about the noise. No problem. Thanks for the review.