From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758303AbcAKHb6 (ORCPT ); Mon, 11 Jan 2016 02:31:58 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35522 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbcAKHb4 (ORCPT ); Mon, 11 Jan 2016 02:31:56 -0500 Date: Mon, 11 Jan 2016 07:31:52 +0000 From: Lee Jones To: Charles Keepax Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, robh@kernel.org Subject: Re: [PATCH v2 1/2] mfd: arizona: Add device tree binding to specify mono outputs Message-ID: <20160111073152.GY3331@x1> References: <1450088352-10470-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450088352-10470-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Dec 2015, Charles Keepax wrote: > Add device tree bindings to support specifying outputs from the chip as > mono outputs. Whilst we are doing it change the out_mono pdata from a > bool to an int, because Sparse gets upset about using ARRAY_SIZE on > bools. > > Signed-off-by: Charles Keepax > --- > > No changes since v1. > > Thanks, > Charles > > drivers/mfd/arizona-core.c | 10 ++++++++++ > include/linux/mfd/arizona/pdata.h | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index b9489a0..4bb4866 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -861,6 +861,16 @@ static int arizona_of_get_core_pdata(struct arizona *arizona) > count++; > } > > + count = 0; > + of_property_for_each_u32(arizona->dev->of_node, "wlf,out-mono", prop, > + cur, val) { > + if (count == ARRAY_SIZE(pdata->out_mono)) > + break; > + > + pdata->out_mono[count] = !!val; > + count++; > + } > + > return 0; > } > > diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h > index 57b45ca..64faeef 100644 > --- a/include/linux/mfd/arizona/pdata.h > +++ b/include/linux/mfd/arizona/pdata.h > @@ -171,7 +171,7 @@ struct arizona_pdata { > int inmode[ARIZONA_MAX_INPUT]; > > /** Mode for outputs */ > - bool out_mono[ARIZONA_MAX_OUTPUT]; > + int out_mono[ARIZONA_MAX_OUTPUT]; > > /** PDM speaker mute setting */ > unsigned int spk_mute[ARIZONA_MAX_PDM_SPK]; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog