From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758897AbcAKI4D (ORCPT ); Mon, 11 Jan 2016 03:56:03 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33972 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758291AbcAKI4A (ORCPT ); Mon, 11 Jan 2016 03:56:00 -0500 Date: Mon, 11 Jan 2016 08:55:55 +0000 From: Lee Jones To: xuejiancheng Cc: mturquette@baylibre.com, sboyd@codeaurora.org, p.zabel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, arnd@arndb.de, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com, suwenping@hisilicon.com, ml.yang@hisilicon.com, gaofei@hisilicon.com, zhangzhenxing@hisilicon.com, xuejiancheng@hisilicon.com Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Message-ID: <20160111085555.GE14104@x1> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56935EA8.4060801@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2016, xuejiancheng wrote: > On 2016/1/11 13:48, Lee Jones wrote: > > On Fri, 08 Jan 2016, Jiancheng Xue wrote: > > > >> Add device tree bindings for Hi3519 system controller. > >> > >> Signed-off-by: Jiancheng Xue > >> --- > >> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt > > > > I have this patch, but none of the others in the set, thus I am > > lacking context. > > > I can forward other patches in the set to you. Thank you. > > >> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt > >> new file mode 100644 > >> index 0000000..115c5be > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt > >> @@ -0,0 +1,14 @@ > >> +* Hisilicon Hi3519 System Controller Block > >> + > >> +This bindings use the following binding: > >> +Documentation/devicetree/bindings/mfd/syscon.txt > >> + > >> +Required properties: > >> +- compatible: "hisilicon,hi3519-sysctrl". > >> +- reg: the register region of this block > >> + > >> +Examples: > >> +sysctrl: system-controller@12010000 { > >> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; > >> + reg = <0x12010000 0x1000>; > >> +}; > > > > There is no requirement (nor want) for binding documents where the > > given device is simply using highly generic bindings. This just > > amounts to churn. > > > This block is specific for Hi3519 SOC, and may has its own driver. Does it have its own driver currently? > So I think it's better to keep this binding. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog