From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758765AbcAKJ2r (ORCPT ); Mon, 11 Jan 2016 04:28:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38651 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757332AbcAKJ2p (ORCPT ); Mon, 11 Jan 2016 04:28:45 -0500 Date: Mon, 11 Jan 2016 10:28:41 +0100 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.or, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH 1/6] perf tools: Add -lutil in python lib list for broken python-config Message-ID: <20160111092841.GC15415@krava.brq.redhat.com> References: <1452263041-225488-1-git-send-email-wangnan0@huawei.com> <1452263041-225488-2-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452263041-225488-2-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 02:23:56PM +0000, Wang Nan wrote: > On some system the perf-config is broken, causes link failure like this: > > /usr/lib64/python2.7/config/libpython2.7.a(posixmodule.o): In function `posix_forkpty': > /opt/wangnan/yocto-build/tmp-eglibc/work/x86_64-oe-linux/python/2.7.3-r0.3.1/Python-2.7.3/./Modules/posixmodule.c:3816: undefined reference to `forkpty' > /usr/lib64/python2.7/config/libpython2.7.a(posixmodule.o): In function `posix_openpty': > /opt/wangnan/yocto-build/tmp-eglibc/work/x86_64-oe-linux/python/2.7.3-r0.3.1/Python-2.7.3/./Modules/posixmodule.c:3756: undefined reference to `openpty' > collect2: error: ld returned 1 exit status > make[1]: *** [/home/wangnan/kernel-hydrogen/tools/perf/out/perf] Error 1 > make: *** [all] Error 2 > > $ python-config --libs > -lpthread -ldl -lpthread -lutil -lm -lpython2.7 so your 'python-config --libs' shows -lutil and you still get the build failure? after your fix I can see double -lutil in PYTHON_EMBED_LIBADD, which is probably not a problem but could be ommited I think > > In this case a '-lutil' should be appended to -lpython2.7. > > (I know we have --start-group and --end-group. I can see them in > command line of collect2 by strace. However it doesn't work. Seems > I have a broken environment?) hum, how is this related to start/end -group options? thanks, jirka