From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758935AbcAKJ3i (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 04:29:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44292 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758242AbcAKJ3g (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 04:29:36 -0500
Date: Mon, 11 Jan 2016 10:29:33 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.or, lizefan@huawei.com,
        pi3orama@163.com, linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 3/6] perf tools: Fix phony build target for build-test
Message-ID: <20160111092933.GD15415@krava.brq.redhat.com>
References: <1452263041-225488-1-git-send-email-wangnan0@huawei.com>
 <1452263041-225488-4-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452263041-225488-4-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 08, 2016 at 02:23:58PM +0000, Wang Nan wrote:
> make_kernelsrc and make_kernelsrc_tools are skiped if a previous
> build-test is done, because 'make build-test' creates two files with
> same names. To avoid this, they should be included in .PHONY list.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  tools/perf/tests/make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index c1fbb8e..130be7c 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -280,5 +280,5 @@ all: $(run) $(run_O) tarpkg make_kernelsrc make_kernelsrc_tools
>  out: $(run_O)
>  	@echo OK
>  
> -.PHONY: all $(run) $(run_O) tarpkg clean
> +.PHONY: all $(run) $(run_O) tarpkg clean make_kernelsrc make_kernelsrc_tools
>  endif # ifndef MK
> -- 
> 1.8.3.4
>